[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-15 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083999#comment-17083999 ] Mario Emmenlauer commented on THRIFT-5109: -- I'm not proficient enough to code the Gruntfile

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-15 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083895#comment-17083895 ] Mario Emmenlauer commented on THRIFT-5109: -- Actually I think I have isolated the problem now.

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-15 Thread Jano Svitok (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083853#comment-17083853 ] Jano Svitok commented on THRIFT-5109: - Another guess: npm install complains about vulnerable

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-14 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083385#comment-17083385 ] Mario Emmenlauer commented on THRIFT-5109: -- {quote} Mario, please see my edit. {quote} Hmm,

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-14 Thread Jano Svitok (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083355#comment-17083355 ] Jano Svitok commented on THRIFT-5109: - Mario, please see my edit. > Misc CMake improvements >

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-14 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083302#comment-17083302 ] Mario Emmenlauer commented on THRIFT-5109: -- > Would [this

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-14 Thread Jano Svitok (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083290#comment-17083290 ] Jano Svitok commented on THRIFT-5109: - Would [this

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-14 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083278#comment-17083278 ] Mario Emmenlauer commented on THRIFT-5109: -- Or could someone test this branch locally? I have

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-09 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079004#comment-17079004 ] Mario Emmenlauer commented on THRIFT-5109: -- I may need help with a small issue, or otherwise

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078998#comment-17078998 ] Jens Geyer commented on THRIFT-5109: {quote} And would you like all commits in a single PR, or split

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-08 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078644#comment-17078644 ] Mario Emmenlauer commented on THRIFT-5109: -- [~janosvitok] as you suggested, boost is no longer

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-08 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078420#comment-17078420 ] Mario Emmenlauer commented on THRIFT-5109: -- Ok I'll check. And would you like all commits in a

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-08 Thread Jano Svitok (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078408#comment-17078408 ] Jano Svitok commented on THRIFT-5109: - I suspect that boost is not needed anymore in

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-04-08 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078397#comment-17078397 ] Mario Emmenlauer commented on THRIFT-5109: -- I will rebase the PR's now onto latest master.

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-03-02 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049084#comment-17049084 ] Mario Emmenlauer commented on THRIFT-5109: -- Sorry for this mess. I'm happy to fix my changes

[jira] [Commented] (THRIFT-5109) Misc CMake improvements

2020-02-28 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047865#comment-17047865 ] Jens Geyer commented on THRIFT-5109: I just reverted them. > Misc CMake improvements >