[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2021-07-24 Thread Triton Circonflexe (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386766#comment-17386766 ] Triton Circonflexe commented on THRIFT-5300: I think there has been a misunderstanding: -

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2021-07-24 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386690#comment-17386690 ] Jens Geyer commented on THRIFT-5300: {quote}So my understanding is that the part in TCompactProtocol

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-11-04 Thread Zezeng Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226446#comment-17226446 ] Zezeng Wang commented on THRIFT-5300: - [~LinShuo] {code} how can same function returns different

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-11-03 Thread shuo li (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225754#comment-17225754 ] shuo li commented on THRIFT-5300: - [~allengeorge] and [~fishywang]: yes, that is my understanding too.

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-11-03 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225622#comment-17225622 ] Yuxuan Wang commented on THRIFT-5300: - After reading more, the ids defined in the lists and sets

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-11-03 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225607#comment-17225607 ] Yuxuan Wang commented on THRIFT-5300: - I took a reading on the go, java and cpp code on the current

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-11-02 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225130#comment-17225130 ] Allen George commented on THRIFT-5300: -- [~shuoli84] This is what I get for trying to squeeze in

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-11-02 Thread shuo li (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225116#comment-17225116 ] shuo li commented on THRIFT-5300: - {code:java} #[test] fn must_write_small_sized_list_begin() {

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-11-02 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224972#comment-17224972 ] Allen George commented on THRIFT-5300: -- [~shuoli84][~ulidtko] I just checked the spec again (it's

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-11-01 Thread shuo li (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224415#comment-17224415 ] shuo li commented on THRIFT-5300: - [~zeshuai007] I'm confused, while reading code of cpp, in

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-10-31 Thread Zezeng Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224020#comment-17224020 ] Zezeng Wang commented on THRIFT-5300: - I check the implementations in cpp.The implementation is

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-10-30 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223679#comment-17223679 ] Max commented on THRIFT-5300: - Hey [~allengeorge] what is the expected process to address bugs in

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-10-30 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223676#comment-17223676 ] Allen George commented on THRIFT-5300: -- I'm closing this out because it's a bug in the spec, not a

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-10-28 Thread shuo li (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222637#comment-17222637 ] shuo li commented on THRIFT-5300: - [~allengeorge] I double checked other implementations (golang cpp

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-10-28 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1720#comment-1720 ] Allen George commented on THRIFT-5300: -- I'm surprised I forgot those two. I'm pretty sure I would

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-10-28 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222022#comment-17222022 ] Jens Geyer commented on THRIFT-5300: Instead of linking to the well-known source file, can you

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

2020-10-28 Thread shuo li (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221988#comment-17221988 ] shuo li commented on THRIFT-5300: -