[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2021-02-22 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288781#comment-17288781 ] Allen George commented on THRIFT-5314: -- I've taken a crack at this here:

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-12-02 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242811#comment-17242811 ] Jens Geyer commented on THRIFT-5314: You need a vote to make one implementation consistent with all

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-12-02 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242743#comment-17242743 ] Yuxuan Wang commented on THRIFT-5314: - I'm in favor to make it consistent (making rust's enum

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-12-02 Thread Remi Dettai (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242731#comment-17242731 ] Remi Dettai commented on THRIFT-5314: - I don't really have a point of view on what the invariants of

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-12-02 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242708#comment-17242708 ] Yuxuan Wang commented on THRIFT-5314: - [~WiredWolf] so enums can be considered as "documented i32

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-12-02 Thread Z M (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242671#comment-17242671 ] Z M commented on THRIFT-5314: - [~jensg] thanks for your comments. Wholly deprecating an 'optional' field

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-12-02 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242628#comment-17242628 ] Jens Geyer commented on THRIFT-5314: Note that whether or not the logic of a particular piece of

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-12-02 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242620#comment-17242620 ] Jens Geyer commented on THRIFT-5314: {quote} You refer to Thrift' "soft versioning" but I don't see

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-12-02 Thread Z M (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242300#comment-17242300 ] Z M commented on THRIFT-5314: - [~jensg] [~allengeorge] The Parquet file that started this thread (in the

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-11-19 Thread Remi Dettai (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235585#comment-17235585 ] Remi Dettai commented on THRIFT-5314: - I must admit that I don't understand why Flatbuffer ended up

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-11-19 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235560#comment-17235560 ] Allen George commented on THRIFT-5314: -- I don't think that's necessary. You could have the same

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-11-19 Thread Remi Dettai (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235525#comment-17235525 ] Remi Dettai commented on THRIFT-5314: - I love Rusd enums so much! Sadly I am not sure that they are

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-11-18 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235158#comment-17235158 ] Allen George commented on THRIFT-5314: -- What should the right behavior be? If the receiver gets a

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

2020-11-17 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233868#comment-17233868 ] Jens Geyer commented on THRIFT-5314: > Is this intended? Thrift APIs are allowing for