[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-08-01 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391182#comment-17391182 ] Allen George commented on THRIFT-5392: -- I don't mind reverting the change and then just using an

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-08-01 Thread Jira
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391145#comment-17391145 ] Jorge Leitão commented on THRIFT-5392: -- I also do not understand why not using native rust enums.

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-04-08 Thread Samuele Maci (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317234#comment-17317234 ] Samuele Maci commented on THRIFT-5392: -- {quote}I avoided doing this because names in Thrift are not

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-04-08 Thread Samuele Maci (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317119#comment-17317119 ] Samuele Maci commented on THRIFT-5392: -- I was writing specifically about the comment and trying to

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-04-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317114#comment-17317114 ] Allen George commented on THRIFT-5392: -- This is a separate concern for a separate ticket:

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-04-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317112#comment-17317112 ] Allen George commented on THRIFT-5392: -- Also note that your concern: {noformat} // we allow

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-04-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317108#comment-17317108 ] Allen George commented on THRIFT-5392: -- Link to the comment where I considered it:

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

2021-04-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317107#comment-17317107 ] Allen George commented on THRIFT-5392: -- I considered using a sentinel value, but note that it would