[jira] [Commented] (THRIFT-627) should c++ have setters for optional fields?

[ https://issues.apache.org/jira/browse/THRIFT-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501933#comment-13501933 ] Marcin Zieleń commented on THRIFT-627: -- Why setter __set_field() modifies the __isset

[jira] [Commented] (THRIFT-627) should c++ have setters for optional fields?

[ https://issues.apache.org/jira/browse/THRIFT-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054451#comment-13054451 ] Hudson commented on THRIFT-627: --- Integrated in Thrift #177 (See [https://builds.apache.org/j

[jira] [Commented] (THRIFT-627) should c++ have setters for optional fields?

[ https://issues.apache.org/jira/browse/THRIFT-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053549#comment-13053549 ] Eric Rannaud commented on THRIFT-627: - Should this change really uppercase the first l

[jira] Commented: (THRIFT-627) should c++ have setters for optional fields?

[ https://issues.apache.org/jira/browse/THRIFT-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005216#comment-13005216 ] David Reiss commented on THRIFT-627: The pointers check can be moved outside of the lo

[jira] Commented: (THRIFT-627) should c++ have setters for optional fields?

[ https://issues.apache.org/jira/browse/THRIFT-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005202#comment-13005202 ] Bryan Duxbury commented on THRIFT-627: -- David - feel like giving a last thumbs up bef

[jira] Commented: (THRIFT-627) should c++ have setters for optional fields?

[ https://issues.apache.org/jira/browse/THRIFT-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004904#comment-13004904 ] Diwaker Gupta commented on THRIFT-627: -- I've cleaned up the patch and incorporated Da

[jira] Commented: (THRIFT-627) should c++ have setters for optional fields?

[ https://issues.apache.org/jira/browse/THRIFT-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969020#action_12969020 ] Adam Simpkins commented on THRIFT-627: -- The setter method names could also conflict wi

[jira] Commented: (THRIFT-627) should c++ have setters for optional fields?

[ https://issues.apache.org/jira/browse/THRIFT-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969013#action_12969013 ] David Reiss commented on THRIFT-627: No need to generate these at all if "pointers" is

[jira] Commented: (THRIFT-627) should c++ have setters for optional fields?

[ https://issues.apache.org/jira/browse/THRIFT-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968867#action_12968867 ] Bryan Duxbury commented on THRIFT-627: -- The spacing seems to be off - are you using ta