TNonblockingServer: pass in the connection context to
-------------------------------------------------------
Key: THRIFT-1304
URL: https://issues.apache.org/jira/browse/THRIFT-1304
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
Attachments:
0023-TNonblockingServer-pass-in-the-connection-context-to.patch
>From aa5cdf5b40e046b41a0c61e521dba0e78e1887b0 Mon Sep 17 00:00:00 2001
From: Adam Simpkins <simpk...@fb.com>
Date: Sat, 17 Apr 2010 01:10:15 +0000
Subject: [PATCH 23/33] TNonblockingServer: pass in the connection context to
process()
Summary:
When using TNonblockingServer without a ThreadManager, it always passed
NULL to process(), instead of passing in the context returned by
TProcessorEventHandler::getContext(). This was broken and could cause
TProcessorEventHandlers to crash, since they expected to get the value
they had previously returned via getContext().
Test Plan:
Ran the test code in [fb unittest]. The non-threaded TNonblockingServer tests
no longer crash.
Revert Plan:
OK
---
lib/cpp/src/server/TNonblockingServer.cpp | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
