Wade Simmons created THRIFT-2591: ------------------------------------ Summary: TFramedTransport does not handle payloads split across packets correctly Key: THRIFT-2591 URL: https://issues.apache.org/jira/browse/THRIFT-2591 Project: Thrift Issue Type: Bug Components: Node.js - Library Affects Versions: 0.9.1, 0.9.2 Reporter: Wade Simmons
There are a few bugs in the current TFramedTransport.receiver caused by merge mistakes and bad patches. This patch fixes the bugs and simplifies the logic so it is easier to reason about and prevent future issues. - THRIFT-2194: Fixed one bug with residual not being set - THRIFT-2205: Reverted the above fix (by accident) and broke it further by including InputBufferUnderrunError in TFramedTransport (which is incorrect). This exception is only meant for TBufferedTransport which must use exceptions to signal when more data is needed. This patch cleans up TFramedTransport.receiver by only using one hold-over buffer instead of two (previously {{frame}} and {{residual}}, now just the latter). Verified that the current tests still pass. -- This message was sent by Atlassian JIRA (v6.2#6252)