alisdair sullivan created THRIFT-2628:
-----------------------------------------

             Summary: erlang backend doesn't support repeated names
                 Key: THRIFT-2628
                 URL: https://issues.apache.org/jira/browse/THRIFT-2628
             Project: Thrift
          Issue Type: Bug
          Components: Erlang - Compiler, Erlang - Library
            Reporter: alisdair sullivan


the erlang backend generates records to represent structs. instead of the 
unique sequential id they use the struct field name as the record keys. records 
in erlang do not support repeated keys so generated erlang modules do not 
compile

the most obvious fix is to refuse to generate code from structs with repeated 
keys but this means the erlang backend is not capable of handling all valid 
structs

the easiest fix is to switch structs to use the unique sequential ids as the 
keys of the record but this breaks backwards compatibility and probably 
necessitates generating helper functions to retrieve fields by name

also possible is switching to an erlang data structure that supports repeated 
keys but this would also require breaking backwards compatibility

also possible

possible fixes are to refuse to generate code from structs with repeated keys, 
switch generated records to use the unique sequential ids as the key or switch 
to an erlang data structure that supports repeated keys (probably a proplist)





--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to