Tom Lee created THRIFT-3431: ------------------------------- Summary: Avoid "schemes" HashMap lookups during struct reads/writes Key: THRIFT-3431 URL: https://issues.apache.org/jira/browse/THRIFT-3431 Project: Thrift Issue Type: Improvement Components: Java - Compiler Affects Versions: 0.9.3 Reporter: Tom Lee Priority: Minor
Generated Java code for structs doesn't need to do a HashMap lookup on every read/write operation. Was surprised to see this show up in profilers under certain high throughput, write-heavy loads. Unclear if the cost was in the hashCode() implementation of the key or in the map lookup itself, but given this map never changes, for now it seems like it can be pretty safely replaced with a simple (and, in most cases, predictable) branch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)