Jano Svitok created THRIFT-5128: ----------------------------------- Summary: Swift TFramedTransport does not work using present code Key: THRIFT-5128 URL: https://issues.apache.org/jira/browse/THRIFT-5128 Project: Thrift Issue Type: Bug Components: Swift - Compiler, Swift - Library Affects Versions: 0.14.0 Reporter: Jano Svitok
These are TFrameTransport related issues from THRIFT-5125. # _TFramedTransport.flush_ is not called anywhere; therefore, the message is never sent. _outProtocol.transport.flush_ should be added to generated processors after _outProtocol.writeMessageEnd_, and also after writeException. # _TFramedTransport.remainingBytes_ are not reset anywhere, thus the header of second and further messages are not processed properly # _TFramedTransport.flush_ incorrectly checks if buffer >= headerSize (got there by incorrectly porting code COCOA lib) # _TFramedTransport_ does not read the whole message from the underlaying transport at once (that I understand is the whole point of TFramedTransport) Notes: * 1. needs compiler changes -- This message was sent by Atlassian Jira (v8.3.4#803005)