Wes McKinney created THRIFT-5137:
------------------------------------

             Summary: Version 0.13.0 require CMake 3.10 or higher
                 Key: THRIFT-5137
                 URL: https://issues.apache.org/jira/browse/THRIFT-5137
             Project: Thrift
          Issue Type: Bug
          Components: C++ - Library
    Affects Versions: 0.13.0
            Reporter: Wes McKinney


The "include_guard" function was introduced in CMake 3.10

https://github.com/apache/thrift/blob/master/build/cmake/FindClangTools.cmake#L11

Since library builders don't need to use clang-tidy it seems like you shouldn't 
want the build to fail like this. 

Example failure

https://github.com/apache/arrow/pull/6572/checks?check_run_id=499747124



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to