Christopher Friedt created THRIFT-5665:
------------------------------------------

             Summary: include-order issue in TSocket.cpp
                 Key: THRIFT-5665
                 URL: https://issues.apache.org/jira/browse/THRIFT-5665
             Project: Thrift
          Issue Type: Bug
          Components: C++ - Library
            Reporter: Christopher Friedt


Looks like another include-order issue, this time in TSocket.cpp. This would be 
avoided if the headers were included directly in PlatformSocket.h.
{code:java}
In file included from 
/Users/cfriedt/workspace/zephyrproject/modules/lib/thrift/.upstream/lib/cpp/src/thrift/Thrift.h:23,
                 from 
/Users/cfriedt/workspace/zephyrproject/modules/lib/thrift/.upstream/lib/cpp/src/thrift/concurrency/Exception.h:24,
                 from 
/Users/cfriedt/workspace/zephyrproject/modules/lib/thrift/.upstream/lib/cpp/src/thrift/concurrency/Monitor.h:24,
                 from 
/Users/cfriedt/workspace/zephyrproject/modules/lib/thrift/.upstream/lib/cpp/src/thrift/transport/TSocket.cpp:49:
/Users/cfriedt/workspace/zephyrproject/modules/lib/thrift/.upstream/lib/cpp/src/thrift/transport/TSocket.cpp:
 In member function 'virtual bool 
apache::thrift::transport::TSocket::hasPendingDataToRead()':
/Users/cfriedt/workspace/zephyrproject/modules/lib/thrift/.upstream/lib/cpp/src/thrift/transport/PlatformSocket.h:110:31:
 error: 'ioctl' was not declared in this scope
  110 | #  define THRIFT_IOCTL_SOCKET ioctl
      |                               ^~~~~
/Users/cfriedt/workspace/zephyrproject/modules/lib/thrift/.upstream/lib/cpp/src/thrift/transport/TSocket.cpp:191:11:
 note: in expansion of macro 'THRIFT_IOCTL_SOCKET'
  191 |   int r = THRIFT_IOCTL_SOCKET(socket_, FIONREAD, &numBytesAvailable);
      |           ^~~~~~~~~~~~~~~~~~~
[190/210] Building CXX object CMakeFiles/app.dir/src/main.cpp.obj
In file included from 
/Users/cfriedt/zephyr-sdk-0.15.0/arm-zephyr-eabi/arm-zephyr-eabi/include/c++/12.1.0/map:60,
                 from 
/Users/cfriedt/workspace/zephyrproject/modules/lib/thrift/.upstream/lib/cpp/src/thrift/Thrift.h:38,
                 from 
/Users/cfriedt/workspace/zephyrproject/modules/lib/thrift/.upstream/lib/cpp/src/thrift/transport/TTransport.h:23,
                 from 
/Users/cfriedt/workspace/zephyrproject/modules/lib/thrift/.upstream/lib/cpp/src/thrift/protocol/TProtocol.h:28,
                 from 
/Users/cfriedt/workspace/zephyrproject/modules/lib/thrift/.upstream/lib/cpp/src/thrift/protocol/TBinaryProtocol.h:23,
                 from 
/Users/cfriedt/workspace/zephyrproject/modules/lib/thrift/tests/lib/thrift/ThriftTest/src/main.cpp:11:
 {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to