[ https://issues.apache.org/jira/browse/THRIFT-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251862#comment-13251862 ]
Joshua Garvin edited comment on THRIFT-1412 at 4/11/12 7:28 PM: ---------------------------------------------------------------- Roger, This must've been my fault -- and I'm surprised that it compiles without warning on my end. There is an extra ending squiggly brace on line 99 just prior to the #region " IDisposable Support " in TBufferedTransport.cs. Remove that extra brace and everything should work as expected. Thanks, - Joshua was (Author: jkaldon): Roger, This must've been my fault -- and I'm surprised that it compiles without warning on my end. There is an extra ending squiggly brace just prior to the #region " IDisposable Support " in TBufferedTransport.cs. Remove that extra brace and everything should work as expected. Thanks, - Joshua > Thrift Transport classes should manage the lifetime of objects implementing > IDisposable by implementing IDisposable themselves. > ------------------------------------------------------------------------------------------------------------------------------- > > Key: THRIFT-1412 > URL: https://issues.apache.org/jira/browse/THRIFT-1412 > Project: Thrift > Issue Type: Improvement > Components: C# - Library > Affects Versions: 0.7 > Reporter: Joshua Garvin > Labels: patch > Attachments: Thrift Transport with IDisposable.patch, > Thrift-trunk-iDisposable v2.patch, Thrift-trunk-iDisposable.patch > > > I have attached a patch to the C# Transport classes to implement IDisposable > where needed. This will ensure that all unmanaged resources such as streams > and sockets are properly closed and freed from memory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira