[ https://issues.apache.org/jira/browse/THRIFT-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Maykov updated THRIFT-481: ------------------------------- Attachment: thrift-481-wip.patch Here is a candidate patch. The approach is really simple: create a subclass of std::ofstream that contains the indent level and has the methods: indent(), indent_up(), indent_down(). Then change the types of the 3 open files (f_types_, f_constants_, f_service_) to the new class and refactor all code to call the indent methods. Also does a bit of whitespace formatting (break up some long lines, combine some short lines) and adds a missing indent when generating docstring comments. > indentation of ruby classes is off by a few > ------------------------------------------- > > Key: THRIFT-481 > URL: https://issues.apache.org/jira/browse/THRIFT-481 > Project: Thrift > Issue Type: Bug > Components: Ruby - Compiler > Affects Versions: 0.1 > Reporter: Bryan Duxbury > Assignee: Ilya Maykov > Priority: Trivial > Attachments: thrift-481-wip.patch > > > For some reason it looks like the generator indents more than it outdents in > some strange way, leading to the end of the file being indented several > columns -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira