[ 
https://issues.apache.org/jira/browse/THRIFT-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Wojniak updated THRIFT-4896:
----------------------------------
    Description: AM_CPPFLAGS is used by cpp and c_glib. They both add their 
include directories to AM_CPPFLAGS. However, since thrift header files names 
are generic (e.g. Processor.h) and can be reused per language, like with cpp 
and cocoa (as of 0.12), there is possibility for conflict due cpp and cocoa 
using same header file names. Automake supports target_CPPFLAGS instead which 
appears to limit the compile flags scope.  (was: AM_CPPFLAGS is used by cpp and 
c_glib. They both add their include directories to AM_CPPFLAGS. However, since 
thrift header files are generic and can be reused per language, like with cpp 
and cocoa (as of 0.12), there is possibility for conflict due cpp and cocoa 
using same header file names. Automake supports target_CPPFLAGS instead which 
appears to limit the compile flags scope.)

> AM_CPPFLAGS and other global flags should be avoided
> ----------------------------------------------------
>
>                 Key: THRIFT-4896
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4896
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process
>            Reporter: Kevin Wojniak
>            Priority: Major
>
> AM_CPPFLAGS is used by cpp and c_glib. They both add their include 
> directories to AM_CPPFLAGS. However, since thrift header files names are 
> generic (e.g. Processor.h) and can be reused per language, like with cpp and 
> cocoa (as of 0.12), there is possibility for conflict due cpp and cocoa using 
> same header file names. Automake supports target_CPPFLAGS instead which 
> appears to limit the compile flags scope.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to