[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13079623#comment-13079623
]
Roger Meier commented on THRIFT-916:
no compiler warnings on CI! see
[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13079624#comment-13079624
]
Hudson commented on THRIFT-916:
---
Integrated in Thrift #215 (See
[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13070051#comment-13070051
]
Hudson commented on THRIFT-916:
---
Integrated in Thrift #193 (See
[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13068033#comment-13068033
]
Christian Lavoie commented on THRIFT-916:
-
Works for me on both Mac OS X and my
[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13066712#comment-13066712
]
Roger Meier commented on THRIFT-916:
just committed another cleanup, no warnings with
[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12964559#action_12964559
]
Christian Lavoie commented on THRIFT-916:
-
{{THRIFT-916_fix_no-overflow.patch}}
[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12935533#action_12935533
]
Christian Lavoie commented on THRIFT-916:
-
Committed a modified v4: should work
[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12934550#action_12934550
]
David Reiss commented on THRIFT-916:
-Wall should not be in CPPFLAGS. CPPFLAGS is for
[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12934552#action_12934552
]
Christian Lavoie commented on THRIFT-916:
-
Any preferences as to where it goes?
[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12934555#action_12934555
]
David Reiss commented on THRIFT-916:
CXXFLAGS for C++ and CFLAGS for C.
gcc warnings
[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12934300#action_12934300
]
Roger Meier commented on THRIFT-916:
Christian, your patch
On both machines we should use int64_t or w\e is appropriate.
On 19 Nov 2010 16:49, Piotr Bartosiewicz (JIRA) j...@apache.org wrote:
[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12933996#action_12933996]
[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12933193#action_12933193
]
Roger Meier commented on THRIFT-916:
Christian, Piotr = thanks for review!
just
[
https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929390#action_12929390
]
Christian Lavoie commented on THRIFT-916:
-
Btw, if you're curious, the warnings I
14 matches
Mail list logo