[jira] [Commented] (THRIFT-916) gcc warnings in c++ header files

2011-08-04 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13079623#comment-13079623 ] Roger Meier commented on THRIFT-916: no compiler warnings on CI! see

[jira] [Commented] (THRIFT-916) gcc warnings in c++ header files

2011-08-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13079624#comment-13079624 ] Hudson commented on THRIFT-916: --- Integrated in Thrift #215 (See

[jira] [Commented] (THRIFT-916) gcc warnings in c++ header files

2011-07-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13070051#comment-13070051 ] Hudson commented on THRIFT-916: --- Integrated in Thrift #193 (See

[jira] [Commented] (THRIFT-916) gcc warnings in c++ header files

2011-07-19 Thread Christian Lavoie (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13068033#comment-13068033 ] Christian Lavoie commented on THRIFT-916: - Works for me on both Mac OS X and my

[jira] [Commented] (THRIFT-916) gcc warnings in c++ header files

2011-07-17 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13066712#comment-13066712 ] Roger Meier commented on THRIFT-916: just committed another cleanup, no warnings with

[jira] Commented: (THRIFT-916) gcc warnings in c++ header files

2010-11-28 Thread Christian Lavoie (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12964559#action_12964559 ] Christian Lavoie commented on THRIFT-916: - {{THRIFT-916_fix_no-overflow.patch}}

[jira] Commented: (THRIFT-916) gcc warnings in c++ header files

2010-11-24 Thread Christian Lavoie (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12935533#action_12935533 ] Christian Lavoie commented on THRIFT-916: - Committed a modified v4: should work

[jira] Commented: (THRIFT-916) gcc warnings in c++ header files

2010-11-22 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12934550#action_12934550 ] David Reiss commented on THRIFT-916: -Wall should not be in CPPFLAGS. CPPFLAGS is for

[jira] Commented: (THRIFT-916) gcc warnings in c++ header files

2010-11-22 Thread Christian Lavoie (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12934552#action_12934552 ] Christian Lavoie commented on THRIFT-916: - Any preferences as to where it goes?

[jira] Commented: (THRIFT-916) gcc warnings in c++ header files

2010-11-22 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12934555#action_12934555 ] David Reiss commented on THRIFT-916: CXXFLAGS for C++ and CFLAGS for C. gcc warnings

[jira] Commented: (THRIFT-916) gcc warnings in c++ header files

2010-11-21 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12934300#action_12934300 ] Roger Meier commented on THRIFT-916: Christian, your patch

Re: [jira] Commented: (THRIFT-916) gcc warnings in c++ header files

2010-11-19 Thread Christian Lavoie
On both machines we should use int64_t or w\e is appropriate. On 19 Nov 2010 16:49, Piotr Bartosiewicz (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12933996#action_12933996]

[jira] Commented: (THRIFT-916) gcc warnings in c++ header files

2010-11-17 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12933193#action_12933193 ] Roger Meier commented on THRIFT-916: Christian, Piotr = thanks for review! just

[jira] Commented: (THRIFT-916) gcc warnings in c++ header files

2010-11-07 Thread Christian Lavoie (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929390#action_12929390 ] Christian Lavoie commented on THRIFT-916: - Btw, if you're curious, the warnings I