Just took a look. +1
On Tue, Jun 9, 2020 at 12:59 AM max ulidtko wrote:
> Hi list,
>
> I'm the PR author — calling out for reviewers!
>
> The diff is under 1 kLoC.
>
> I have it well-groomed already:
> • CI bots are green;
> • new code is clang-formatted;
> • entry in CHANGES.md added;
> •
Hi list,
I'm the PR author — calling out for reviewers!
The diff is under 1 kLoC.
I have it well-groomed already:
• CI bots are green;
• new code is clang-formatted;
• entry in CHANGES.md added;
• both buildsystems adjusted for new file;
• non-pertinent changes split off;
• Jens Geyer's
Hi Jens and all,
I'll try to spend a bit of time with the PR and validate the code
works for us. I'm not sure I qualify as a reviewer yet but I'll at
least try to make an informed guess.
The PR does indeed address a relevant concern: currently Thrift C++
server sockets will only pick _one_ of
Hi all,
the PR creator is a bit hesitant about it, so I ask for him:
If there is any C++ developer out there who feels like spending a share of
his/her valuable time to review this PR, that would be a great thing. But be
warned, there is a reason for this request: The patch is a bit more
