Re: Compiler plug-ins

2017-10-29 Thread Ben Craig
> and easy. A low level platform upon which you can build your own higher > level abstractions. > > -1 compiler plug ins > -1 recursive data structs > etc... > > --Randy > > On Sun, Oct 29, 2017 at 9:50 AM, Jens Geyer wrote: > > > > > Not so long ago some

Re: Compiler plug-ins

2017-10-29 Thread Randy Abernethy
I am a fan of tenacious elimination of complexity. Thrift should be fast and easy. A low level platform upon which you can build your own higher level abstractions. -1 compiler plug ins -1 recursive data structs etc... --Randy On Sun, Oct 29, 2017 at 9:50 AM, Jens Geyer wrote: > > Not s

Re: Compiler plug-ins

2017-10-29 Thread Jens Geyer
t I personally (I can only speak for myself) don't need it. Have fun, JensG -Ursprüngliche Nachricht- From: James E. King, III Sent: Sunday, October 29, 2017 3:38 PM To: dev@thrift.apache.org Subject: Compiler plug-ins I'm curious if anyone uses the thrift compiler pl

Re: Compiler plug-ins

2017-10-29 Thread Allen George
We don't. (As in, the company I work for). AFAIK, Twitter doesn't as well, but I'd love for someone there to confirm. From: James E. King, III Sent: Sunday, October 29, 2017 10:38:37 AM To: dev@thrift.apache.org Subject: Compiler plug-ins I'

Compiler plug-ins

2017-10-29 Thread James E. King, III
I'm curious if anyone uses the thrift compiler plug-in feature? It adds a complexity to the build system and the compiler, and if it does not provide value, it should be considered for removal. I'd like to know what the use cases are for having a binary plug-in system when the source code is free

[GitHub] thrift pull request #1157: THRIFT-4033 disable compiler plug-ins for standar...

2017-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] thrift issue #1157: THRIFT-4033 disable compiler plug-ins for standard debia...

2017-01-19 Thread jfarrell
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1157 sure, or modify the ticket description to 'disable compiler plug-ins by default for all builds' --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift issue #1157: THRIFT-4033 disable compiler plug-ins for standard debia...

2017-01-19 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1157 I'm okay making the default for plug-in support "OFF", and you have to enable it specifically. Would it be okay to merge this as it fixes the ticket as described, and open a new one to change the g

[GitHub] thrift issue #1157: THRIFT-4033 disable compiler plug-ins for standard debia...

2017-01-19 Thread jfarrell
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1157 We have had issues with plugin support being on by default in a couple build instances now, and this does not fix when we pull out autoconf that it wont reappear with cmake. I'd like to see us chan

[GitHub] thrift issue #1157: THRIFT-4033 disable compiler plug-ins for standard debia...

2017-01-19 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1157 @jfarrell I'd like one review of this before I merge it. It did fix the issue I had with the stock 0.10.0 debian package for the compiler not working. --- If your project is set up for it, you can

[GitHub] thrift pull request #1157: THRIFT-4033 disable compiler plug-ins for standar...

2017-01-16 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1157 THRIFT-4033 disable compiler plug-ins for standard debian build as the thrift-compiler packaging is not ready for it yet You can merge this pull request into a Git repository by running