Re: Looking for +1s to several of my patches

2013-10-08 Thread Jens Geyer
Hi Ben, 2027 applies fine for me on a clean git tree. $ git apply ../ben-2027-misc_minor.patch ../ben-2027-misc_minor.patch:10: trailing whitespace. nextIOThread_ = static_castuint32_t((nextIOThread_ + 1) % ioThreads_.size() ; ../ben-2027-misc_minor.patch:19: trailing whitespace. long

Looking for +1s to several of my patches

2013-10-07 Thread Ben Craig
I've got a long list of patches that I need someone to review. https://issues.apache.org/jira/browse/THRIFT-1750 https://issues.apache.org/jira/browse/THRIFT-1751 https://issues.apache.org/jira/browse/THRIFT-1892 https://issues.apache.org/jira/browse/THRIFT-2019

Re: Looking for +1s to several of my patches

2013-10-07 Thread Jens Geyer
Hi Ben, I tried a few of the simpler and/or MinGW related ones but unfortunately they all do not apply cleanly. In particular, I looked at 2027, 2031 and 2045 so far. Jens -Ursprüngliche Nachricht- From: Ben Craig Sent: Monday, October 7, 2013 4:41 PM To: dev@thrift.apache.org

Re: Looking for +1s to several of my patches

2013-10-07 Thread Ben Craig
From: Jens Geyer jensge...@hotmail.com To: dev@thrift.apache.org, Date: 10/07/2013 02:25 PM Subject: Re: Looking for +1s to several of my patches Hi Ben, I tried a few of the simpler and/or MinGW related ones but unfortunately they all do not apply cleanly. In particular, I looked at