I've noticed three code merges this month that were made without the github build job passing:
THRIFT-3825 THRIFT-3834 THRIFT-3849 As a general rule, we should not be merging code into the project proper unless it passes all of the github pull request builds: Apache, Travis, and Appveyor. Right now we're blocked on THRIFT-3850. There should be a moratorium on code merges until this is resolved. If we continue to merge code into the project without successful builds, we will not be able to easily understand which commit may have introduced a regression. I am not a committer, just a submitter, so this is not a communication of an official decision. Just a suggestion... [Description: Description: simplivity-lg-xsmall] James E. King, III Architect 8 Technology Drive, 2nd Floor Westborough, MA 01581-1756 Ph: 855-SVT-INFO --------------------------------------------------------------------------------------- PRIVACY STATEMENT: This message is a PRIVATE communication. This message and all attachments are a private communication sent by SimpliVity and are considered to be confidential or protected by privilege. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or use of the information contained in or attached to this message is strictly prohibited. Please notify the sender of the delivery error by replying to this message, and then delete it from your system. ---------------------------------------------------------------------------------------
