t; https://github.com/apache/thrift/commit/33fb1a3f0da71ba79e3156f7d0c169e7480fcf26#diff-c6a81da7e9ec5ce3c040a3386a790b69
> >
> > - Jim
> >
> > On Wed, Jul 17, 2019 at 5:33 PM Jeff Nelson wrote:
> > >
> > > The changelog says that THRIFT-3769 was shipped with 0.12.0 but the
:
>
> The changelog says that THRIFT-3769 was shipped with 0.12.0 but the jar on
> maven central and the state of the code at the 0.12.0 tag doesn’t have the
> relevant changes
> (https://github.com/apache/thrift/blob/v0.12.0/lib/java/src/org/apache/thrift/server/TThread
lines for issues. "Fix logic of
X" does nothing to summarize the problem. In this case, the summary could be
something like:
"TThreadPoolServer does not log TTransportExceptions at the correct level"
> Fix logic of THRIFT-3769
>
>
>
[
https://issues.apache.org/jira/browse/THRIFT-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mithun Radhakrishnan updated THRIFT-4805:
-
Labels: Breaking-Change (was: )
> Fix logic of THRIFT-3
:
---
Hey, [~vihangk1]. I'm grateful for your continued interest and scrutiny of this
patch.
{quote}I am a bit confused when you say ".. correct the behavior of
THRIFT-3769".
{quote}
I apologize for my lack of clarity. I'd be happy to consider changing the title
of this Jira, ba
continued interest and scrutiny of this
patch.
{quote}I am a bit confused when you say ".. correct the behavior of
THRIFT-3769".
{quote}
I apologize for my lack of clarity. I'd be happy to consider the title of this
Jira, based on our discussion here.
{quote}Can you give a example stack t
[
https://issues.apache.org/jira/browse/THRIFT-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775496#comment-16775496
]
Vihang Karajgaonkar commented on THRIFT-4805:
-
Linking THRIFT-3769
> Fix logic of THR
. I am a bit confused when you say
".. correct the behavior of THRIFT-3769". Can you give a example stack trace
which was not being printed before and gets logged after THRIFT-3769? My
understanding is that with this patch we are suppressing types of exceptions
which is a super-set o
Fix logic of THRIFT-3769
>
>
> Key: THRIFT-4805
> URL: https://issues.apache.org/jira/browse/THRIFT-4805
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
>
: https://github.com/apache/thrift/pull/1745
> Fix logic of THRIFT-3769
>
>
> Key: THRIFT-4805
> URL: https://issues.apache.org/jira/browse/THRIFT-4805
> Project: Thrift
> Issue Type: Bug
>
gic of THRIFT-3769
>
>
> Key: THRIFT-4805
> URL: https://issues.apache.org/jira/browse/THRIFT-4805
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
>Affects Versions: 0
[
https://issues.apache.org/jira/browse/THRIFT-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mithun Radhakrishnan updated THRIFT-4805:
-
Description:
This has to do with the fix checked in for THRIFT-3769 and THRIFT
of a patch file.
Right you are. Will do, very shortly.
> Fix logic of THRIFT-3769
>
>
> Key: THRIFT-4805
> URL: https://issues.apache.org/jira/browse/THRIFT-4805
> Project: Thrift
> Issue Type: Bug
file.
> Fix logic of THRIFT-3769
>
>
> Key: THRIFT-4805
> URL: https://issues.apache.org/jira/browse/THRIFT-4805
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
>
HRIFT-4773, on {{master}}. :/ I'll
upload a less brittle version, but this is the intention.
> Fix logic of THRIFT-3769
>
>
> Key: THRIFT-4805
> URL: https://issues.apache.org/jira/browse/THRIFT-4805
> Proj
it into our CI environment for
QA.
> Fix logic of THRIFT-3769
>
>
> Key: THRIFT-4805
> URL: https://issues.apache.org/jira/browse/THRIFT-4805
> Project: Thrift
> Issue Type: Bug
> Co
:
---
In the first patch
[THRIFT-4805.1.patch|https://issues.apache.org/jira/secure/attachment/12958947/THRIFT-4805.1.patch],
I aim to correct the behaviour introduced in THRIFT-3769.
One possible fault (in my patch above, and in the original fix to THRIFT-3769)
is that all
[
https://issues.apache.org/jira/browse/THRIFT-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mithun Radhakrishnan updated THRIFT-4805:
-
Attachment: THRIFT-4805.bonus.patch
> Fix logic of THRIFT-3
|https://issues.apache.org/jira/secure/attachment/12958947/THRIFT-4805.1.patch],
I aim to correct the behaviour introduced in THRIFT-3769.
One possible fault (in my patch above, and in the original fix to THRIFT-3769)
is that all {{TTransportExceptions}} are suppressed. But there might
but ignore the RuntimeExceptions
which were thrown by the loadbalancer health checks. The patch attached will
ignore all the TTransportExceptions. Is that intentional?
> Fix logic of THRIFT-3769
>
>
> Key: THRIFT-4805
>
on this originally, for their expertise:
[~thiruvel], [~vihangk1], [~jking3]
> Fix logic of THRIFT-3769
>
>
> Key: THRIFT-4805
> URL: https://issues.apache.org/jira/browse/THRIFT-4805
> Project: Thrift
>
[
https://issues.apache.org/jira/browse/THRIFT-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mithun Radhakrishnan updated THRIFT-4805:
-
Attachment: (was: THRIFT-4805.1.patch)
> Fix logic of THRIFT-3
[
https://issues.apache.org/jira/browse/THRIFT-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mithun Radhakrishnan updated THRIFT-4805:
-
Attachment: THRIFT-4805.1.patch
> Fix logic of THRIFT-3
[
https://issues.apache.org/jira/browse/THRIFT-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mithun Radhakrishnan updated THRIFT-4805:
-
Attachment: THRIFT-4805.1.patch
> Fix logic of THRIFT-3
[
https://issues.apache.org/jira/browse/THRIFT-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mithun Radhakrishnan updated THRIFT-4805:
-
Description:
This has to do with the fix checked in for THRIFT-3769 and THRIFT
[
https://issues.apache.org/jira/browse/THRIFT-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mithun Radhakrishnan updated THRIFT-4805:
-
Description:
This has to do with the fix checked in for THRIFT-3769 and THRIFT
[
https://issues.apache.org/jira/browse/THRIFT-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mithun Radhakrishnan updated THRIFT-4805:
-
Description:
This has to do with the fix checked in for THRIFT-3769 and THRIFT
Mithun Radhakrishnan created THRIFT-4805:
Summary: Fix logic of THRIFT-3769
Key: THRIFT-4805
URL: https://issues.apache.org/jira/browse/THRIFT-4805
Project: Thrift
Issue Type: Bug
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III closed THRIFT-3769.
-
> Fix logic of THRIFT-2268
>
>
> Key:
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460345#comment-16460345
]
James E. King III commented on THRIFT-3769:
---
The project has not retroactively applied patches
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460166#comment-16460166
]
Vihang Karajgaonkar commented on THRIFT-3769:
-
Hi [~jking3] Is it possible to get this patch
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460155#comment-16460155
]
Vihang Karajgaonkar commented on THRIFT-3769:
-
Thanks for committing the patch [~jking3]. Do
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-3769.
Resolution: Fixed
Fix Version/s: 0.12.0
Committed - thanks.
> Fix lo
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-3769:
--
Assignee: James E. King, III
> Fix logic of THRIFT-2
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459652#comment-16459652
]
ASF GitHub Bot commented on THRIFT-3769:
jeking3 closed pull request #1543: THRIFT-3769 : Fix
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457260#comment-16457260
]
Vihang Karajgaonkar commented on THRIFT-3769:
-
ping [~jking3]
> Fix logic of THRIFT-2
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440097#comment-16440097
]
Vihang Karajgaonkar commented on THRIFT-3769:
-
oh sorry :) I thought you were based on your
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440093#comment-16440093
]
Sergey Shelukhin commented on THRIFT-3769:
--
LGTM but I'm not a committer
> Fix logic of THR
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440087#comment-16440087
]
Vihang Karajgaonkar commented on THRIFT-3769:
-
ping [~jking3] [~sershe]
> Fix lo
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437733#comment-16437733
]
Vihang Karajgaonkar commented on THRIFT-3769:
-
Moving this forward. When load balancers like
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437731#comment-16437731
]
ASF GitHub Bot commented on THRIFT-3769:
vihangk1 opened a new pull request #1543: THRIFT-3769
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985627#comment-15985627
]
James E. King, III edited comment on THRIFT-3769 at 4/26/17 9:47 PM
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985627#comment-15985627
]
James E. King, III commented on THRIFT-3769:
A pull request with the patch needs to be opened
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985525#comment-15985525
]
Sergey Shelukhin commented on THRIFT-3769:
--
Looks like a simple patch... should this be included
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985526#comment-15985526
]
Sergey Shelukhin commented on THRIFT-3769:
--
Looks like a simple patch... should this be included
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J updated THRIFT-3769:
Patch Info: Patch Available
> Fix logic of THRIFT-2268
>
>
>
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J updated THRIFT-3769:
Flags: Patch
> Fix logic of THRIFT-2268
>
>
> Key:
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226580#comment-15226580
]
Harsh J commented on THRIFT-3769:
-
Post THRIFT-2268, the load balancers will generate these obscure
[
https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harsh J updated THRIFT-3769:
Attachment: THRIFT-3769.patch
Attached patch checks for TTransportException instance types within
Harsh J created THRIFT-3769:
---
Summary: Fix logic of THRIFT-2268
Key: THRIFT-3769
URL: https://issues.apache.org/jira/browse/THRIFT-3769
Project: Thrift
Issue Type: Bug
Components: Java
50 matches
Mail list logo
