Re: golang tests fail (due to new gomock behaviour)

Not sure what you mean by "backwards compatible", but (a) this change affects only tests (b) the reason it's needed is that the golang tests pull in gomock, but without a specific version. So anybody who runs tests starting 11/28 is going to pull in the new gomock, and need this patch, I

Re: golang tests fail (due to new gomock behaviour)

Hi Chet, I don't know go that well, but I appreciate your effort on go and rust lately - thank you. In terms of this, as long as it's backwards compatible then I think we're good. - Jim On Tue, Dec 12, 2017 at 3:56 PM, Chet Murthy wrote: > Synopsis: "make check" in

golang tests fail (due to new gomock behaviour)

Synopsis: "make check" in lib/go fails b/c gomock no longer allows multiple Finish() calls on a gomock Controller. that change was made on 11/28/17. I'm just finishing a PR that will fix this, but figured maybe I should post it too. As you can see, it's pretty simplistic -- just reNew the