Hey Anastasija,
To be honest 9am EST is a little aggressive, I will likely be able
to do 6:40 am PT (am traveling back from DC as I type this) which
is 9:40am ET.
My GChat handle is chris.mattm...@gmail.com. I will create a hangout
and send to the list please contact me at 6:40am PT.
Cheers,
[
https://issues.apache.org/jira/browse/TIKA-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257333#comment-15257333
]
ASF GitHub Bot commented on TIKA-1893:
--
GitHub user mkampasi opened a pull request:
GitHub user mkampasi opened a pull request:
https://github.com/apache/tika/pull/110
fix for TIKA-1893 contributed by mkampasi
Added a custom parser class for parsing Apple ICNS files.
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/TIKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256870#comment-15256870
]
Nick C commented on TIKA-1513:
--
Tested more files using the full regex and haven't had any false positives. :D
+1 go ahead and re-enable clirr-maven-plugin.
Thanks Konstantin!
++
Chris Mattmann, Ph.D.
Chief Architect
Instrument Software and Science Data Systems Section (398)
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office:
OK, I'll bring them back into o.a.tika.language tommorow if no objections
will follow until tommorow.
I don't see any ways to break something by doing this but I will recheck
it.
Should I also enable clirr-maven-plugin on these classes?
пн, 25 апр. 2016 г. в 20:39, Mattmann, Chris A (3980) <
+1 I am fine with:
1. putting the old classes back in. Fine by me.
2. keeping the new tika-langdetect and improvements.
I think that this is the easiest. Sorry for breaking
the trunk, apologies. I was just eager to backport Ken’s
stuff and also to get Text.jl support.
Let’s just add back
On Mon, 25 Apr 2016, Allison, Timothy B. wrote:
Thank you, Konstantin, for catching this. I agree about breaking
changes in trunk.
We do have a check (clirr-maven-plugin) to ensure that we don't
accidentally make backwards-incompatible changes on tika-core, but sadly
it looks like it's
+1
Thank you, Konstantin, for catching this. I agree about breaking changes in
trunk.
Should we plop the old classes back where they were, add deprecation and live
with a bit of messiness for a few versions?
-Original Message-
From: Konstantin Gribov [mailto:gros...@gmail.com]
Hi, folks.
I want to bring our attention to maintaining backward compatibility on
master/1.x branch. I've recently found that we dropped
o.a.tika.language.LanguageIdentifier in 3a7a94c[1] (merged on 2016-03-07,
see [2] also). It will brake downstream dependants of `tika-core` which use
Thanks Tim I appreciate it
++
Chris Mattmann, Ph.D.
Chief Architect
Instrument Software and Science Data Systems Section (398)
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 168-519, Mailstop: 168-527
Email:
All,
Given a number of recent changes, I kicked off the regression tests again. I
should have results by tomorrow.
Best,
Tim
12 matches
Mail list logo