[jira] [Commented] (TIKA-3144) Detecting hprof memory dump files exported from Android Studio

2020-08-03 Thread chenshuming (Jira)
[ https://issues.apache.org/jira/browse/TIKA-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170529#comment-17170529 ] chenshuming commented on TIKA-3144: --- > Hahahahahaha...y, I found this too. I had to rename the file. Me

Re: Should we add Apache Commons Lang to tika-core as a dependency?

2020-08-03 Thread Keith Bennett
Uwe - Could you say more about the library being obsolete? How much of the Commons functionality do newer versions of Java add? And which version of Java is the earliest one on which running Tika is supported (i.e. can our code rely on features of newer Java versions, and if so, which one(s))?

Re: Should we add Apache Commons Lang to tika-core as a dependency?

2020-08-03 Thread Uwe Schindler
-1 Please don't add this dependency. Most of this library is obsolete with newer Java versions and for the remaining ones it's easy to add simple code. Uwe Am August 3, 2020 2:25:54 PM UTC schrieb Nicholas DiPiazza : >I've found myself wanting it there before and this is so widely used

Re: Should we add Apache Commons Lang to tika-core as a dependency?

2020-08-03 Thread Nicholas DiPiazza
I've found myself wanting it there before and this is so widely used everywhere, not likely to cause any classpath issues. On Mon, Aug 3, 2020 at 3:24 AM Nick Burch wrote: > On Mon, 3 Aug 2020, Peter Lee wrote: > > I'm working with TIKA-3141 recently and pushed a PR in github. As Keith > >

Re: Should we add Apache Commons Lang to tika-core as a dependency?

2020-08-03 Thread Nick Burch
On Mon, 3 Aug 2020, Peter Lee wrote: I'm working with TIKA-3141 recently and pushed a PR in github. As Keith suggested in the PR, maybe we should add Commons Lang to tika-core, as it seems Commons Lang are being used elsewhere in tika but not tika-core. Historically, we have tried to keep

Should we add Apache Commons Lang to tika-core as a dependency?

2020-08-03 Thread Peter Lee
Hi all, I'm working with TIKA-3141 recently and pushed a PR in github. As Keith suggested in the PR, maybe we should add Commons Lang to tika-core, as it seems Commons Lang are being used elsewhere in tika but not tika-core. Ideas? cheers, Lee

[GitHub] [tika] PeterAlfredLee commented on a change in pull request #334: Tika-3141 : add empty environment variable handle

2020-08-03 Thread GitBox
PeterAlfredLee commented on a change in pull request #334: URL: https://github.com/apache/tika/pull/334#discussion_r464218911 ## File path: tika-core/src/main/java/org/apache/tika/config/TikaConfig.java ## @@ -249,11 +249,11 @@ public TikaConfig(ClassLoader loader) public