[GitHub] [tika] PeterAlfredLee commented on pull request #369: Use IOException instead of IOExceptionWithCause

2020-10-19 Thread GitBox
PeterAlfredLee commented on pull request #369: URL: https://github.com/apache/tika/pull/369#issuecomment-712531011 @kkrugler Thank you for reviewing this. >I don't see the IOExceptionWithCause class being deprecated `IOExceptionWithCause` in `Tika` was copying from `commons-io 1.4`

[GitHub] [tika] PeterAlfredLee commented on pull request #369: Use IOException instead of IOExceptionWithCause

2020-10-19 Thread GitBox
PeterAlfredLee commented on pull request #369: URL: https://github.com/apache/tika/pull/369#issuecomment-712624719 I'm also agree to remove the `IOExceptionWithCause` class from Tika. The reason why this PR wasn't removing `IOExceptionWithCause` class is because consider [TaggedIOExcept

[GitHub] [tika] PeterAlfredLee commented on pull request #369: Use IOException instead of IOExceptionWithCause

2020-10-20 Thread GitBox
PeterAlfredLee commented on pull request #369: URL: https://github.com/apache/tika/pull/369#issuecomment-713233915 > TaggedIOException can just extend IOException, yes? Yes, it is. > I'd take a look at the mailing list archives to get the full context of that discussion (I thi

[GitHub] [tika] PeterAlfredLee commented on pull request #369: Use IOException instead of IOExceptionWithCause

2020-10-21 Thread GitBox
PeterAlfredLee commented on pull request #369: URL: https://github.com/apache/tika/pull/369#issuecomment-714174957 > My memory was that we had agreed to add commons-io to tika-core in 2.x, and Bob already did that in the 2.x branch, I haven't had a chance to port those updates to main yet.

[GitHub] [tika] PeterAlfredLee commented on pull request #369: Use IOException instead of IOExceptionWithCause

2020-12-27 Thread GitBox
PeterAlfredLee commented on pull request #369: URL: https://github.com/apache/tika/pull/369#issuecomment-751546770 Hey folks. I'm thinking about merging this before the release of Tika 2.0. WDYT? This is an automated message

[GitHub] [tika] PeterAlfredLee commented on pull request #369: Use IOException instead of IOExceptionWithCause

2020-12-28 Thread GitBox
PeterAlfredLee commented on pull request #369: URL: https://github.com/apache/tika/pull/369#issuecomment-751912397 > that you would delete the IOExceptionWithCause class. Did that happen separately? Well, this is already finished in #370. ---