Re: [PR] TIKA-4181 - Tika Pipes Grpc Server [tika]

2024-04-15 Thread via GitHub
nddipiazza commented on code in PR #1702: URL: https://github.com/apache/tika/pull/1702#discussion_r1566194105 ## tika-pipes/tika-grpc/src/main/proto/tika.proto: ## @@ -0,0 +1,92 @@ +// Copyright 2015 The gRPC Authors +// +// Licensed under the Apache License, Version 2.0 (the

Re: [PR] TIKA-4181 - Tika Pipes Grpc Server [tika]

2024-04-15 Thread via GitHub
nddipiazza commented on code in PR #1702: URL: https://github.com/apache/tika/pull/1702#discussion_r1566193576 ## tika-pipes/tika-grpc/src/main/proto/tika.proto: ## @@ -0,0 +1,92 @@ +// Copyright 2015 The gRPC Authors +// +// Licensed under the Apache License, Version 2.0 (the

Re: [PR] TIKA-4181 - Tika Pipes Grpc Server [tika]

2024-04-01 Thread via GitHub
bartek commented on code in PR #1702: URL: https://github.com/apache/tika/pull/1702#discussion_r1546235205 ## tika-pipes/tika-grpc/src/main/proto/tika.proto: ## @@ -0,0 +1,92 @@ +// Copyright 2015 The gRPC Authors +// +// Licensed under the Apache License, Version 2.0 (the

Re: [PR] TIKA-4181 - Tika Pipes Grpc Server [tika]

2024-04-01 Thread via GitHub
bartek commented on code in PR #1702: URL: https://github.com/apache/tika/pull/1702#discussion_r1546232766 ## tika-pipes/tika-grpc/src/main/proto/tika.proto: ## @@ -0,0 +1,92 @@ +// Copyright 2015 The gRPC Authors +// +// Licensed under the Apache License, Version 2.0 (the

Re: [PR] TIKA-4181 - Tika Pipes Grpc Server [tika]

2024-03-31 Thread via GitHub
nddipiazza commented on code in PR #1702: URL: https://github.com/apache/tika/pull/1702#discussion_r1545858447 ## tika-pipes/tika-grpc/src/main/proto/tika.proto: ## @@ -0,0 +1,90 @@ +// Copyright 2015 The gRPC Authors +// +// Licensed under the Apache License, Version 2.0 (the

Re: [PR] TIKA-4181 - Tika Pipes Grpc Server [tika]

2024-03-31 Thread via GitHub
nddipiazza commented on code in PR #1702: URL: https://github.com/apache/tika/pull/1702#discussion_r1545858324 ## tika-pipes/tika-grpc/src/main/proto/tika.proto: ## Review Comment: i did the normal proto linter. i'm going to leave the other stuff there that buf extension

Re: [PR] TIKA-4181 - Tika Pipes Grpc Server [tika]

2024-03-31 Thread via GitHub
bartek commented on code in PR #1702: URL: https://github.com/apache/tika/pull/1702#discussion_r1545596130 ## tika-pipes/tika-grpc/src/main/proto/tika.proto: ## @@ -0,0 +1,90 @@ +// Copyright 2015 The gRPC Authors +// +// Licensed under the Apache License, Version 2.0 (the

Re: [PR] TIKA-4181 - Tika Pipes Grpc Server [tika]

2024-03-29 Thread via GitHub
bartek commented on code in PR #1702: URL: https://github.com/apache/tika/pull/1702#discussion_r1544981545 ## tika-pipes/tika-grpc/src/main/proto/tika.proto: ## Review Comment: For your consideration @nddipiazza, I ran `buf lint` on this protobuf (as I am syncing it to a

Re: [PR] TIKA-4181 - Tika Pipes Grpc Server [tika]

2024-03-29 Thread via GitHub
bartek commented on code in PR #1702: URL: https://github.com/apache/tika/pull/1702#discussion_r1544981545 ## tika-pipes/tika-grpc/src/main/proto/tika.proto: ## Review Comment: For your consideration @nddipiazza, I ran `buf lint` on this protobuf (as I am syncing it to a