[ 
https://issues.apache.org/jira/browse/TIKA-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154828#comment-15154828
 ] 

Tim Allison edited comment on TIKA-1855 at 2/19/16 8:39 PM:
------------------------------------------------------------

Step 1 is now done: the shared test code is all back in core-test, and we 
should be good to go on 2.x.

Step 2: I moved all the test files to the appropriate parser module 
subdirectories, but I have to halt that task for a bit.  

I created a new branch (2.x-test-doc-reshuffle) that at least records progress 
I was able to make today.  

The build makes it up through the individual parser-sub-modules and then 
explodes in tika-parsers, as it should because I didn't have a chance to touch 
that yet.

I now view tika-parsers as a tika-parser-integration-test module, and I think 
we can get rid of the two src/main/java classes that are left (as we discussed) 
and leave this effectively as a module to test the combination of parsers...or 
we could move that into tika-app (as proposed by [~bobpaulin]?  I think?), but 
let's hold off on that move for a bit.

To "copy" test docs from the parser-child-modules to tika-parsers for the 
integration tests, I was going to follow Bob's lead (in reverse) and create 
test-jars for the parser-child-modules and then have tika-parsers unpack 
those...is this reasonable?  Or is there a better way for tika-parsers to use 
the files that are now in the parser-child-modules?  

[~kkrugler] and [~bobpaulin] and others, what do you think of this rough sketch?


was (Author: talli...@mitre.org):
Step 1 is now done: the shared test code is all back in core-test, and we 
should be good to go.

Step 2: I moved all the test files to the appropriate parser module 
subdirectories, but I have to halt that task for a bit.  

I created a new branch (2.x-test-doc-reshuffle) that at least records progress 
I was able to make today.  

The build makes it up through the individual parser-sub-modules and then 
explodes in tika-parsers, as it should because I didn't have a chance to touch 
that yet.

I now view tika-parsers as a tika-parser-integration-test module, and I think 
we can get rid of the two src/main/java classes that are left (as we discussed) 
and leave this effectively as a module to test the combination of parsers...or 
we could move that into tika-app (as proposed by Bob?  I think?), but let's 
hold off on that move for a bit.

To "copy" test docs from the parser-child-modules to tika-parsers for the 
integration tests, I was going to follow Bob's lead (in reverse) and create 
test-jars for the parser-child-modules and then have tika-parsers unpack 
those...is this reasonable?  Or is there a better way for tika-parsers to use 
the files that are now in the parser-child-modules?  





> TIka 2.0 - Move shared test-code back to tika-core and distribute test files 
> to parser modules
> ----------------------------------------------------------------------------------------------
>
>                 Key: TIKA-1855
>                 URL: https://issues.apache.org/jira/browse/TIKA-1855
>             Project: Tika
>          Issue Type: Sub-task
>            Reporter: Tim Allison
>            Assignee: Tim Allison
>
> Undo TIKA-1851, and divide test docs to appropriate parser modules.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to