[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301289#comment-17301289
]
Hudson commented on TIKA-3310:
--
SUCCESS: Integrated in Jenkins build Tika » tika-branch1x-jdk8 #98 (See
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301287#comment-17301287
]
Hudson commented on TIKA-3310:
--
SUCCESS: Integrated in Jenkins build Tika » tika-main-jdk8 #168 (See
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301280#comment-17301280
]
Nick Burch commented on TIKA-3310:
--
Thanks for all your help on this [~peterkronenberg] !
> MP4 video
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301279#comment-17301279
]
ASF GitHub Bot commented on TIKA-3310:
--
Gagravarr merged pull request #410:
URL:
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299574#comment-17299574
]
Peter Kronenberg commented on TIKA-3310:
[~nick] What's the delay in merging this?
> MP4 video
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298500#comment-17298500
]
ASF GitHub Bot commented on TIKA-3310:
--
peterkronenberg commented on pull request #410:
URL:
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297730#comment-17297730
]
Peter Kronenberg commented on TIKA-3310:
Can you approve the Pull Request? I can backport it if
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297714#comment-17297714
]
Nick Burch commented on TIKA-3310:
--
Yup, I'm happy with that, thanks for all the work and the revisions!
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297417#comment-17297417
]
Peter Kronenberg commented on TIKA-3310:
[~nick] are you good with the latest version?
> MP4
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296246#comment-17296246
]
Peter Kronenberg commented on TIKA-3310:
Ok, I've gone ahead and separated them. It searches for
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296122#comment-17296122
]
Peter Kronenberg commented on TIKA-3310:
oh yeah, you're right
> MP4 video detected as
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296103#comment-17296103
]
Nick Burch commented on TIKA-3310:
--
I think we need to do the loop twice though, once checking major, and
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296085#comment-17296085
]
Peter Kronenberg commented on TIKA-3310:
done
> MP4 video detected as application/mp4
>
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296080#comment-17296080
]
Peter Kronenberg commented on TIKA-3310:
Ah, now I understand what you're saying. Ok, I will
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296076#comment-17296076
]
Nick Burch commented on TIKA-3310:
--
My worry is, though I don't know if it could happen, is eg major=3g2c
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296065#comment-17296065
]
Peter Kronenberg commented on TIKA-3310:
[~nick] What are your current thoughts? Do you still
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295360#comment-17295360
]
Peter Kronenberg commented on TIKA-3310:
||Major Brand matches||Compatible Brand
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295359#comment-17295359
]
Peter Kronenberg commented on TIKA-3310:
Well, if both a major and compatible brands match, that
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295356#comment-17295356
]
ASF GitHub Bot commented on TIKA-3310:
--
peterkronenberg closed pull request #409:
URL:
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295355#comment-17295355
]
ASF GitHub Bot commented on TIKA-3310:
--
peterkronenberg opened a new pull request #410:
URL:
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295342#comment-17295342
]
Nick Burch commented on TIKA-3310:
--
Could there be a situation where both a major and a compatible brand
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295341#comment-17295341
]
Peter Kronenberg commented on TIKA-3310:
I'm going to delete my fork on Github and re-create it.
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295335#comment-17295335
]
Peter Kronenberg commented on TIKA-3310:
Yeah, the InputStream stuff is my commit from yesterday,
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295333#comment-17295333
]
Nick Burch commented on TIKA-3310:
--
FYI There's a few unrelated changes in the pull request, including
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295325#comment-17295325
]
Peter Kronenberg commented on TIKA-3310:
I went ahead and created a pull request, on the hope that
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295324#comment-17295324
]
ASF GitHub Bot commented on TIKA-3310:
--
peterkronenberg opened a new pull request #409:
URL:
[
https://issues.apache.org/jira/browse/TIKA-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17294592#comment-17294592
]
Tim Allison commented on TIKA-3310:
---
Sounds reasonable? [~nick], any recs?
> MP4 video detected as
27 matches
Mail list logo