Re: Review Request 32291: ISATab parsers (preliminary version)

2015-03-28 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32291/#review78159 --- Ship it! I have ran this in production and it works awesome! Thanks

Re: Review Request 32291: ISATab parsers (preliminary version)

2015-03-28 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32291/#review78158 --- Ship it! Ship It! - Chris Mattmann On March 23, 2015, 5:04 p.m.,

Re: Review Request 32291: ISATab parsers (preliminary version)

2015-03-24 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32291/#review77557 --- trunk/tika-parsers/src/main/java/org/apache/tika/parser/isatab/ISAT

Re: Review Request 32291: ISATab parsers (preliminary version)

2015-03-23 Thread Tyler Palsulich
You can comment on a specific line by clicking on the line number on the left (and a window will pop up). :) Tyler On Mon, Mar 23, 2015 at 3:52 PM, Tim Allison wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 32291: ISATab parsers (preliminary version)

2015-03-23 Thread Tim Allison
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32291/#review77453 --- Apologies, I haven't figured out how to reference specific code snip

Re: Review Request 32291: ISATab parsers (preliminary version)

2015-03-23 Thread Giuseppe Totaro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32291/ --- (Updated March 23, 2015, 5:04 p.m.) Review request for tika and Chris Mattmann.

Re: Review Request 32291: ISATab parsers (preliminary version)

2015-03-22 Thread Giuseppe Totaro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32291/ --- (Updated March 23, 2015, 4:39 a.m.) Review request for tika and Chris Mattmann.