lewismc commented on PR #15:
URL: https://github.com/apache/tika-helm/pull/15#issuecomment-2043768368
Thank you @ahilmathew really nice patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lewismc merged PR #15:
URL: https://github.com/apache/tika-helm/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tika.apache.org
ahilmathew commented on PR #15:
URL: https://github.com/apache/tika-helm/pull/15#issuecomment-2041650193
@lewismc - Updated now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ahilmathew commented on code in PR #15:
URL: https://github.com/apache/tika-helm/pull/15#discussion_r1555104022
##
templates/configmap.yaml:
##
@@ -0,0 +1,9 @@
+{{- if .Values.tikaConfig }}
Review Comment:
@lewismc Done.
--
This is an automated message from the Apache
lewismc commented on code in PR #15:
URL: https://github.com/apache/tika-helm/pull/15#discussion_r1552678442
##
templates/configmap.yaml:
##
@@ -0,0 +1,9 @@
+{{- if .Values.tikaConfig }}
Review Comment:
@ahilmathew please add Apache License v2 file header. Thank you
--
ahilmathew commented on PR #15:
URL: https://github.com/apache/tika-helm/pull/15#issuecomment-2038203402
@lewismc Thanks for the comments. I've updated `values.yaml` to include the
configuration from https://tika.apache.org/2.9.1/configuring.html. Let me know
if there is a specific
lewismc commented on PR #15:
URL: https://github.com/apache/tika-helm/pull/15#issuecomment-2037419324
@ahilmathew please sync with `main` branch and also include the default
oncfiguration in `values.yaml`. Thank you
--
This is an automated message from the Apache Git Service.
To respond
lewismc commented on PR #15:
URL: https://github.com/apache/tika-helm/pull/15#issuecomment-2037419625
@t-l-k understood
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
t-l-k commented on PR #15:
URL: https://github.com/apache/tika-helm/pull/15#issuecomment-2032395440
@lewismc @nddipiazza I'm champing at the bit to to see this merged, xml
configuration essential in Tika v2+
--
This is an automated message from the Apache Git Service.
To respond to the
lewismc commented on PR #15:
URL: https://github.com/apache/tika-helm/pull/15#issuecomment-2028413169
@ahilmathew even if it is commented out by default, I think we should add
the `tikaConfig` element to `values.yaml`.
--
This is an automated message from the Apache Git Service.
To
lewismc commented on PR #15:
URL: https://github.com/apache/tika-helm/pull/15#issuecomment-2020719947
@nddipiazza any feedback? Would be great to get this merged if possible.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ahilmathew commented on code in PR #15:
URL: https://github.com/apache/tika-helm/pull/15#discussion_r1532770531
##
README.md:
##
@@ -84,6 +89,27 @@ while true; do kubectl --namespace tika-test port-forward
$POD_NAME 9998:$CONTAI
* Install it:
- with Helm 3: `helm install
lewismc commented on code in PR #15:
URL: https://github.com/apache/tika-helm/pull/15#discussion_r1516598662
##
README.md:
##
@@ -84,6 +89,27 @@ while true; do kubectl --namespace tika-test port-forward
$POD_NAME 9998:$CONTAI
* Install it:
- with Helm 3: `helm install tika
nddipiazza commented on code in PR #15:
URL: https://github.com/apache/tika-helm/pull/15#discussion_r1511202976
##
README.md:
##
@@ -84,6 +89,27 @@ while true; do kubectl --namespace tika-test port-forward
$POD_NAME 9998:$CONTAI
* Install it:
- with Helm 3: `helm install
lewismc commented on code in PR #15:
URL: https://github.com/apache/tika-helm/pull/15#discussion_r1510519893
##
README.md:
##
@@ -84,6 +89,27 @@ while true; do kubectl --namespace tika-test port-forward
$POD_NAME 9998:$CONTAI
* Install it:
- with Helm 3: `helm install tika
ahilmathew opened a new pull request, #15:
URL: https://github.com/apache/tika-helm/pull/15
Added support for custom tika
[configuration](https://tika.apache.org/1.9/configuring.html) to be used in the
helm chart via the `tikaConfig` key in the `values.yaml`.
This key is optional
16 matches
Mail list logo
