[jira] [Commented] (TINKERPOP-1352) Connection Pool doesn't always grow

2016-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361508#comment-15361508 ] ASF GitHub Bot commented on TINKERPOP-1352: --- Github user ramzioueslati commented on the

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-04 Thread ramzioueslati
Github user ramzioueslati commented on the issue: https://github.com/apache/tinkerpop/pull/352 Successful pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Commented] (TINKERPOP-1352) Connection Pool doesn't always grow

2016-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361483#comment-15361483 ] ASF GitHub Bot commented on TINKERPOP-1352: --- Github user ramzioueslati commented on the

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-04 Thread ramzioueslati
Github user ramzioueslati commented on the issue: https://github.com/apache/tinkerpop/pull/352 Will do right away. For the record here is the stacktrace: ``` Running org.apache.tinkerpop.gremlin.server.GremlinServerAuthOldIntegrateTest [WARN]

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/352 nice find @robertdale - i pushed a fix that removed that assert. that whole test case is deprecated anyway, so i'm not too worried about it. @ramzioueslati care to pull the branch

[jira] [Commented] (TINKERPOP-1352) Connection Pool doesn't always grow

2016-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361375#comment-15361375 ] ASF GitHub Bot commented on TINKERPOP-1352: --- Github user spmallette commented on the issue:

[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0

2016-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361303#comment-15361303 ] ASF GitHub Bot commented on TINKERPOP-1274: --- Github user robertdale commented on the issue:

[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.

2016-07-04 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/351 @newkek @spmallette Sorry, my context was only this thread. I agree with you on all accounts. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (TINKERPOP-1352) Connection Pool doesn't always grow

2016-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361298#comment-15361298 ] ASF GitHub Bot commented on TINKERPOP-1352: --- Github user robertdale commented on the issue:

[jira] [Commented] (TINKERPOP-1352) Connection Pool doesn't always grow

2016-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361273#comment-15361273 ] ASF GitHub Bot commented on TINKERPOP-1352: --- Github user robertdale commented on the issue:

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-04 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/352 Can you provide the stacktrace (from the surefire report)? What OS, java versions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (TINKERPOP-1352) Connection Pool doesn't always grow

2016-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361271#comment-15361271 ] ASF GitHub Bot commented on TINKERPOP-1352: --- Github user ramzioueslati commented on the

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-04 Thread ramzioueslati
Github user ramzioueslati commented on the issue: https://github.com/apache/tinkerpop/pull/352 I tried 3 times with the same result --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (TINKERPOP-1352) Connection Pool doesn't always grow

2016-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361255#comment-15361255 ] ASF GitHub Bot commented on TINKERPOP-1352: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/352 uh - i wasn't aware of any kerberos setup required. does that happen consistently? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (TINKERPOP-1352) Connection Pool doesn't always grow

2016-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361252#comment-15361252 ] ASF GitHub Bot commented on TINKERPOP-1352: --- Github user ramzioueslati commented on the

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

2016-07-04 Thread ramzioueslati
Github user ramzioueslati commented on the issue: https://github.com/apache/tinkerpop/pull/352 Hi Stephen I tried to run the test : ``` mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false ``` It failed : ``` Failed

[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0

2016-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361197#comment-15361197 ] ASF GitHub Bot commented on TINKERPOP-1274: --- Github user spmallette commented on the issue:

Re: [TinkerPop] Re: Traversal ByteCode and Translators (The TINKERPOP-1278 Saga)

2016-07-04 Thread Stephen Mallette
We're pretty close to getting GraphSON 2.0 merged for 3.2.1 on TINKERPOP-1274: https://github.com/apache/tinkerpop/pull/351 2.0 ensures full typing, makes it easier for non-jvm languages to generate/consume it and has a smaller byte size footprint. It would be interesting to see how the JSON for

[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.

2016-07-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/351 Just for reference: https://groups.google.com/d/msg/gremlin-users/R7qQbJXWcH8/wK9ZuWADAwAJ --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] tinkerpop issue #355: TINKERPOP-1355 Design HasContainer for extension

2016-07-04 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/355 Yea, lots of issues in this code area. `enforceHomogenousCollectionIfPresent` also has the potential to throw NPE's (if the first element of a non-empty collection is `null`). I will create

[jira] [Commented] (TINKERPOP-1355) Design HasContainer for extension

2016-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361162#comment-15361162 ] ASF GitHub Bot commented on TINKERPOP-1355: --- Github user dkuppitz commented on the issue:

[GitHub] tinkerpop issue #355: TINKERPOP-1355 Design HasContainer for extension

2016-07-04 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/355 Also the conversion of the collection to an array is dangerous. Who knows what the collection is actually backed by? It should use an iterator and get the first element if it exists. --- If

[jira] [Commented] (TINKERPOP-1355) Design HasContainer for extension

2016-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361141#comment-15361141 ] ASF GitHub Bot commented on TINKERPOP-1355: --- Github user dkuppitz commented on the issue:

[GitHub] tinkerpop issue #355: TINKERPOP-1355 Design HasContainer for extension

2016-07-04 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/355 I just implemented my proposed changes. Now we no longer get exceptions, but unexpected results: ``` gremlin> g.V().hasId(within(new ArrayList())) ==>v[1] ==>v[2] ==>v[3]

[jira] [Commented] (TINKERPOP-1355) Design HasContainer for extension

2016-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361120#comment-15361120 ] ASF GitHub Bot commented on TINKERPOP-1355: --- Github user dkuppitz commented on the issue:

[jira] [Issue Comment Deleted] (TINKERPOP-1355) Design HasContainer for extension

2016-07-04 Thread Bryn Cooke (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryn Cooke updated TINKERPOP-1355: -- Comment: was deleted (was: https://github.com/apache/tinkerpop/pull/355) > Design

[jira] [Commented] (TINKERPOP-1355) Design HasContainer for extension

2016-07-04 Thread Bryn Cooke (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361098#comment-15361098 ] Bryn Cooke commented on TINKERPOP-1355: --- https://github.com/apache/tinkerpop/pull/355 > Design

[jira] [Commented] (TINKERPOP-1355) Design HasContainer for extension

2016-07-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361096#comment-15361096 ] ASF GitHub Bot commented on TINKERPOP-1355: --- GitHub user BrynCooke opened a pull request:

[GitHub] tinkerpop pull request #355: TINKERPOP-1355 Design HasContainer for extensio...

2016-07-04 Thread BrynCooke
GitHub user BrynCooke opened a pull request: https://github.com/apache/tinkerpop/pull/355 TINKERPOP-1355 Design HasContainer for extension You can merge this pull request into a Git repository by running: $ git pull https://github.com/BrynCooke/incubator-tinkerpop

[jira] [Created] (TINKERPOP-1355) Design HasContainer for extension

2016-07-04 Thread Bryn Cooke (JIRA)
Bryn Cooke created TINKERPOP-1355: - Summary: Design HasContainer for extension Key: TINKERPOP-1355 URL: https://issues.apache.org/jira/browse/TINKERPOP-1355 Project: TinkerPop Issue Type: