Perused the code. Looks good.
I noticed there is a travis failure on GroupCountTest however the same
test passes on my machine on branch TINKERPOP-1372.
VOTE +1
On 01/11/2016 16:41, ASF GitHub Bot (JIRA) wrote:
> [
> https://issues.apache.org/jira/browse/TINKERPOP-1372?page=com.atlassian.ji
[
https://issues.apache.org/jira/browse/TINKERPOP-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626914#comment-15626914
]
ASF GitHub Bot commented on TINKERPOP-1211:
---
Github user twilmes commented o
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/475
I grabbed the latest commit and things checked out. Looks good.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Hi,
I had a quick chat with infra@ today and they updated the notification
email address to be this one. Before it was sending to the old incubator
dev email.
Just so you know in case you need to update your mail filters.
Cheers,
Hadrian
[
https://issues.apache.org/jira/browse/TINKERPOP-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626736#comment-15626736
]
ASF GitHub Bot commented on TINKERPOP-1471:
---
Github user dkuppitz commented
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/474#discussion_r86029705
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/decoration/SubgraphStrategy.java
---
@@ -105,21 +105,11 @@ p
[
https://issues.apache.org/jira/browse/TINKERPOP-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626733#comment-15626733
]
ASF GitHub Bot commented on TINKERPOP-1292:
---
GitHub user okram opened a pull
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/476
TINKERPOP-1292: TinkerGraphComputer VertexProgramInterceptors
https://issues.apache.org/jira/browse/TINKERPOP-1292
Added `TinkerGraphCountStrategy` which will translate `g.V().count()` and
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/475#discussion_r86026558
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/UnfoldStep.java
---
@@ -46,6 +47,8 @@ else if (s instanceof I
[
https://issues.apache.org/jira/browse/TINKERPOP-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626693#comment-15626693
]
ASF GitHub Bot commented on TINKERPOP-1211:
---
Github user twilmes commented o
[
https://issues.apache.org/jira/browse/TINKERPOP-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626688#comment-15626688
]
ASF GitHub Bot commented on TINKERPOP-1471:
---
Github user okram commented on
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/474#discussion_r86026278
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/decoration/SubgraphStrategy.java
---
@@ -105,21 +105,11 @@ priv
[
https://issues.apache.org/jira/browse/TINKERPOP-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626677#comment-15626677
]
ASF GitHub Bot commented on TINKERPOP-1471:
---
Github user dkuppitz commented
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/474#discussion_r86025437
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/decoration/SubgraphStrategy.java
---
@@ -105,21 +105,11 @@ p
[
https://issues.apache.org/jira/browse/TINKERPOP-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626577#comment-15626577
]
Marko A. Rodriguez commented on TINKERPOP-1404:
---
Can you VOTE on https:/
[
https://issues.apache.org/jira/browse/TINKERPOP-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626327#comment-15626327
]
ASF GitHub Bot commented on TINKERPOP-1471:
---
Github user dkuppitz commented
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/474
VOTE: +1
A little refactoring would be nice though:
```
for (final Step step : traversal.getSteps()) {
if (step instanceof TraversalParent) {
((TraversalPa
[
https://issues.apache.org/jira/browse/TINKERPOP-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
pieter martin closed TINKERPOP-1404.
Resolution: Fixed
Fix Version/s: 3.3.0
Implemented via TINKERPOP-1372
> Path/lab
[
https://issues.apache.org/jira/browse/TINKERPOP-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626286#comment-15626286
]
pieter martin commented on TINKERPOP-1404:
--
[~okram] has done the primary opt
[
https://issues.apache.org/jira/browse/TINKERPOP-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626225#comment-15626225
]
ASF GitHub Bot commented on TINKERPOP-1211:
---
GitHub user okram opened a pull
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/475
TINKERPOP-1211: UnfoldStep should unfold arrays.
https://issues.apache.org/jira/browse/TINKERPOP-1211
Unfold step now handles unfolding of arrays.
VOTE +1.
You can merge this pull
[
https://issues.apache.org/jira/browse/TINKERPOP-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626177#comment-15626177
]
Marko A. Rodriguez commented on TINKERPOP-620:
--
[~mbroecheler] Is this sti
[
https://issues.apache.org/jira/browse/TINKERPOP-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626166#comment-15626166
]
ASF GitHub Bot commented on TINKERPOP-1471:
---
GitHub user okram opened a pull
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/474
TINKERPOP-1471: IncidentToAdjacentStrategy use hidden marker to avoid
repeated recursion.
https://issues.apache.org/jira/browse/TINKERPOP-1471
Hidden labels can be used by strategies as a
[
https://issues.apache.org/jira/browse/TINKERPOP-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Kuppitz closed TINKERPOP-1537.
-
Resolution: Fixed
Fix Version/s: 3.2.4
CTR'ed via
https://github.com/apache/ti
Daniel Kuppitz created TINKERPOP-1538:
-
Summary: Gremlin Server spawned by test suites should use a
different port
Key: TINKERPOP-1538
URL: https://issues.apache.org/jira/browse/TINKERPOP-1538
Pro
[
https://issues.apache.org/jira/browse/TINKERPOP-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625594#comment-15625594
]
ASF GitHub Bot commented on TINKERPOP-1372:
---
GitHub user okram opened a pull
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/473
TINKERPOP-1372: ImmutablePath should not use Java recursion (call stacks
are wack)
https://issues.apache.org/jira/browse/TINKERPOP-1372
`ImmutablePath` used heavy method-recursion which is
Hi,
So the one thing I just copied into TINKERPOP-1372 was your
ImmutablePath.currentLabels = currentLabels (vs. copying the set). You are
right, step labels are immutable and thus, there is no need to copy the set
over — a direct reference is sufficient. Regarding the
AbstractStep.traverserSt
[
https://issues.apache.org/jira/browse/TINKERPOP-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Kuppitz reassigned TINKERPOP-1537:
-
Assignee: Daniel Kuppitz
> Python tests should not use hard-coded number of w
The branch is TINKERPOP-1404
https://github.com/apache/tinkerpop/commit/c1556fe82c58527dc4425d23d1d69ce324e62cfa
Cheers
Pieter
On 01/11/2016 15:23, Marko Rodriguez wrote:
> What branch are you in? Perhaps give me URLs (to GitHub) to the files
> touched? (if its not too many)
>
> Marko.
>
> http:
What branch are you in? Perhaps give me URLs (to GitHub) to the files touched?
(if its not too many)
Marko.
http://markorodriguez.com
> On Nov 1, 2016, at 7:19 AM, pieter-gmail wrote:
>
> Hi,
>
> Yes I am but afraid I do not have time at present to concentrate on it.
> I just noticed your
Hi,
Yes I am but afraid I do not have time at present to concentrate on it.
I just noticed your ImmutablePath ticket which will overlap with some of
what I have done.
I'd suggest to pull my branch and look at what I did there. It was very
little, but dangerous code, which is why I was reluctant t
[
https://issues.apache.org/jira/browse/TINKERPOP-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625405#comment-15625405
]
Marko A. Rodriguez commented on TINKERPOP-1537:
---
Ah. Yea, that is my bad
Hi Pieter,
I’m still really interested in your work in this area. Are you still doing this?
Marko.
http://markorodriguez.com
> On Aug 7, 2016, at 9:12 AM, Pieter Martin wrote:
>
> To avoid the collection logic alltogether. For most steps there is no need to
> check the labels as it is known
Daniel Kuppitz created TINKERPOP-1537:
-
Summary: Python tests should not use hard-coded number of workers
Key: TINKERPOP-1537
URL: https://issues.apache.org/jira/browse/TINKERPOP-1537
Project: Tink
[
https://issues.apache.org/jira/browse/TINKERPOP-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marko A. Rodriguez reassigned TINKERPOP-1372:
-
Assignee: Marko A. Rodriguez
> ImmutablePath should not use Java recu
Daniel Kuppitz created TINKERPOP-1536:
-
Summary: Include GLVs in Docker build
Key: TINKERPOP-1536
URL: https://issues.apache.org/jira/browse/TINKERPOP-1536
Project: TinkerPop
Issue Type:
[
https://issues.apache.org/jira/browse/TINKERPOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625120#comment-15625120
]
ASF GitHub Bot commented on TINKERPOP-1420:
---
Github user spmallette commente
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/468
I've had three goods builds in a row with docker now on this branch. I also
cleared my containers/images and it's been good since.
---
If your project is set up for it, you can reply to this e
[
https://issues.apache.org/jira/browse/TINKERPOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625045#comment-15625045
]
ASF GitHub Bot commented on TINKERPOP-1420:
---
Github user dkuppitz commented
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/468
So weird. Build succeeded with `docker/build.sh -t -i -n` after I've
rebuilt my containers and removed the `.glv` file from my `gremlin-python`
directory.
VOTE: +1
---
If your project
42 matches
Mail list logo