I am git illiterate.
I committed to my repo.
It looks like that's all I have to do.
Travis build tells me to hang tight.
It knows the commit is related to an open pull request
and your repo knows to pull it in automatically?
That's cool, if true.
-Paul
-Original Message-
From: Paul A. Jack
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/553
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
[
https://issues.apache.org/jira/browse/TINKERPOP-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843540#comment-15843540
]
Marko A. Rodriguez commented on TINKERPOP-1564:
---
Two thoughts today.
1.
[
https://issues.apache.org/jira/browse/TINKERPOP-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Wilmes closed TINKERPOP-1583.
-
Resolution: Fixed
Fix Version/s: 3.2.4
> PathRetractionStrategy retracts keys that are
[
https://issues.apache.org/jira/browse/TINKERPOP-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843524#comment-15843524
]
ASF GitHub Bot commented on TINKERPOP-1617:
---
Github user okram closed the pu
Github user okram closed the pull request at:
https://github.com/apache/tinkerpop/pull/549
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
[
https://issues.apache.org/jira/browse/TINKERPOP-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on TINKERPOP-1602 stopped by Robert Dale.
--
> Support SSL client certificate authentication
> ---
[
https://issues.apache.org/jira/browse/TINKERPOP-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Dale resolved TINKERPOP-1602.
Resolution: Fixed
> Support SSL client certificate authentication
>
[
https://issues.apache.org/jira/browse/TINKERPOP-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Dale closed TINKERPOP-1602.
--
> Support SSL client certificate authentication
> -
[
https://issues.apache.org/jira/browse/TINKERPOP-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843519#comment-15843519
]
ASF GitHub Bot commented on TINKERPOP-1602:
---
Github user asfgit closed the p
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/536
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/553
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
[
https://issues.apache.org/jira/browse/TINKERPOP-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marko A. Rodriguez closed TINKERPOP-1617.
-
Resolution: Fixed
Fix Version/s: 3.2.4
> Create a SingleIterationStrate
[
https://issues.apache.org/jira/browse/TINKERPOP-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843508#comment-15843508
]
ASF GitHub Bot commented on TINKERPOP-1617:
---
Github user dkuppitz commented
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/549
`docker/build.sh -t -i -n` succeeded. Manual tests were showing epic
performance results. Best PR in a long time.
VOTE: +1
---
If your project is set up for it, you can reply to this em
GitHub user GregBestland opened a pull request:
https://github.com/apache/tinkerpop/pull/553
remove tests from setup.py
As previously discussed. Now targeted for the correct branch. Thanks for
the help guys.
You can merge this pull request into a Git repository by running:
$ g
[
https://issues.apache.org/jira/browse/TINKERPOP-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843485#comment-15843485
]
ASF GitHub Bot commented on TINKERPOP-1583:
---
Github user asfgit closed the p
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/546
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user GregBestland closed the pull request at:
https://github.com/apache/tinkerpop/pull/552
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/546
I just tested the `PathRetractionStrategy` code in the GraphActors branch
and the `akka-gremlin/` test suite passes.
*** Sidenote: can you finalize your variables if possible?
VOTE
[
https://issues.apache.org/jira/browse/TINKERPOP-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843387#comment-15843387
]
ASF GitHub Bot commented on TINKERPOP-1583:
---
Github user okram commented on
Hi Stephen,
I think there are two parts to this, and I may have responded to the wrong part.
I can easily and cleanly make those subclasses implement AutoCloseable and
remove that from FlatMapStep.
Implementing AutoCloseable is needed for the second half of the problem, where
a traversal is cl
[
https://issues.apache.org/jira/browse/TINKERPOP-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843356#comment-15843356
]
ASF GitHub Bot commented on TINKERPOP-1583:
---
Github user twilmes commented o
Github user twilmes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/546#discussion_r98270533
--- Diff:
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/PathRetractionStrategyTest.java
---
@@ -37,14 +3
I can do this, and I can see why you are suggesting it, but I didn't originally
because it means overriding all the methods from FlatMapStep into these
subclasses.
The way it's currently designed all the subclasses need to do is implement
flatMap(). FlatMapStep has private access to iterator an
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/551
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
[
https://issues.apache.org/jira/browse/TINKERPOP-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843298#comment-15843298
]
ASF GitHub Bot commented on TINKERPOP-1583:
---
Github user spmallette commente
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/546#discussion_r98261970
--- Diff:
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/PathRetractionStrategyTest.java
---
@@ -37,14
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/551
did a quick build with `mvn clean install` and everything passes. if
@davebshow is cool with this at this point after the his request change, then
VOTE +1
---
If your project is set up for it
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/548
I'm pretty sure @okram was affirming that `VertexStep`, `EdgeVertexStep`
and `PropertiesStep` should implement `AutoCloseable` (I don't think that there
are others) rather than a blanket change
[
https://issues.apache.org/jira/browse/TINKERPOP-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843288#comment-15843288
]
ASF GitHub Bot commented on TINKERPOP-1589:
---
Github user spmallette commente
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/552
I don't know why that was like that. Don't think we had any reason to
include tests that i can think of. Could you please re-target the pull request
at the tp32 branch?
---
If your project
GitHub user GregBestland opened a pull request:
https://github.com/apache/tinkerpop/pull/552
Remove tests from packages
Installing your tests package as part of the setup.py is probably not a
good idea.
Most every python project has a tests module for unit/integration tests
[
https://issues.apache.org/jira/browse/TINKERPOP-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843144#comment-15843144
]
ASF GitHub Bot commented on TINKERPOP-1617:
---
Github user twilmes commented o
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/549
`mvn clean install` was successful. Good set of test cases.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
[
https://issues.apache.org/jira/browse/TINKERPOP-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843138#comment-15843138
]
ASF GitHub Bot commented on TINKERPOP-1589:
---
Github user spmallette commente
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/548
ha - "makes sense" that the way it is now is ok or "makes sense" as with
the change i proposed? :smile:
---
If your project is set up for it, you can reply to this email and have your
reply ap
[
https://issues.apache.org/jira/browse/TINKERPOP-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843136#comment-15843136
]
ASF GitHub Bot commented on TINKERPOP-1589:
---
Github user okram commented on
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/548
Yes. That makes sense to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
[
https://issues.apache.org/jira/browse/TINKERPOP-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843059#comment-15843059
]
ASF GitHub Bot commented on TINKERPOP-1602:
---
Github user twilmes commented o
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/536
Looks good and good doc updates.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
[
https://issues.apache.org/jira/browse/TINKERPOP-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843048#comment-15843048
]
ASF GitHub Bot commented on TINKERPOP-1560:
---
Github user dkuppitz commented
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/541
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user aboudreault commented on the issue:
https://github.com/apache/tinkerpop/pull/551
@davebshow yes, just removed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
[
https://issues.apache.org/jira/browse/TINKERPOP-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843027#comment-15843027
]
ASF GitHub Bot commented on TINKERPOP-1583:
---
Github user dkuppitz commented
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/546
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
[
https://issues.apache.org/jira/browse/TINKERPOP-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843025#comment-15843025
]
ASF GitHub Bot commented on TINKERPOP-1583:
---
Github user dkuppitz commented
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/546
This also fixes
[TINKERPOP-1597](https://issues.apache.org/jira/browse/TINKERPOP-1597), but the
test I've added can only be included in the 3.3.x line, right?
---
If your project is set up for
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/551
This makes a lot of sense. You can probably remove the instance check for
the custom long type after making this change:
https://github.com/apache/tinkerpop/blob/master/gremlin-python/src/main/j
There's a good body of pull requests hanging out there right now. I suppose
we (committers) mostly need to pay attention to the ones pointed at tp32.
Let's see if we can get some votes in so that we can get these merged in
time for code freeze.
On Thu, Jan 26, 2017 at 10:51 AM, Paul A. Jackson
wr
[
https://issues.apache.org/jira/browse/TINKERPOP-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15842952#comment-15842952
]
ASF GitHub Bot commented on TINKERPOP-1589:
---
Github user spmallette commente
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/548
tests all pass with docker so that's good.
@okram would you prefer to not see this change made to `FlatMapStep` and
instead see it implemented specifically in steps that interact with
Github user aboudreault commented on the issue:
https://github.com/apache/tinkerpop/pull/550
closed in favor of: https://github.com/apache/tinkerpop/pull/551
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/546
Made a small update to remove a dependency between `PathRetractionStrategy`
and `MatchPredicateStrategy`. I should also note, this PR addresses
TINKERPOP-1597. TINKERPOP-1597 was entered against
[
https://issues.apache.org/jira/browse/TINKERPOP-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15842918#comment-15842918
]
ASF GitHub Bot commented on TINKERPOP-1583:
---
Github user twilmes commented o
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/551
excellent - thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user aboudreault closed the pull request at:
https://github.com/apache/tinkerpop/pull/550
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user aboudreault commented on the issue:
https://github.com/apache/tinkerpop/pull/551
@spmallette The PR for tp32.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user aboudreault opened a pull request:
https://github.com/apache/tinkerpop/pull/551
Fix the serializers lookup to handle the type first, then the class
inheritance
A good example of the need for this fix is with these types:
datetime.date
datetime.dateti
GitHub user aboudreault reopened a pull request:
https://github.com/apache/tinkerpop/pull/550
Fix the serializers lookup to handle the type first, then the class
inheritance
A good example of the need for this fix is with these types:
* datetime.date
* datetime.datetime
Github user aboudreault closed the pull request at:
https://github.com/apache/tinkerpop/pull/550
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/550
Thanks for this. Could you please edit your pull request at the tp32 branch
so that we can apply this changed to 3.2.4?
---
If your project is set up for it, you can reply to this email and ha
GitHub user aboudreault opened a pull request:
https://github.com/apache/tinkerpop/pull/550
Fix the serializers lookup to handle the type first, then the class
inheritance
A good example of the need for this fix is with these types:
* datetime.date
* datetime.datetime
[
https://issues.apache.org/jira/browse/TINKERPOP-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15842883#comment-15842883
]
Dylan Bethune-Waddell commented on TINKERPOP-1564:
--
Wanted to link a
[
https://issues.apache.org/jira/browse/TINKERPOP-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15842554#comment-15842554
]
ASF GitHub Bot commented on TINKERPOP-1566:
---
Github user mike-tr-adamson com
Github user mike-tr-adamson commented on the issue:
https://github.com/apache/tinkerpop/pull/534
Hi @vtslab, the majority of SASL mechanisms that are suitable for this form
of authentication require some form of credential, be it token or certificate,
at the client end. I agree that t
66 matches
Mail list logo
