Ran Sqlg's own test suite and TinkerPop's structured and process test suites on Sqlg. No failures.
VOTE: +1 Thanks Pieter On 11/02/2017 14:49, Robert Dale wrote: > website passes linkchecker. my app passes all tests. > VOTE +1 > > > Robert Dale > > On Fri, Feb 10, 2017 at 9:14 AM, Stephen Mallette <spmalle...@gmail.com> > wrote: > >> i think it's on schedule still. pieter sounded like he needed a little >> extra time, but given the nature of the issue he described it didn't seem >> like that would ultimately turn up something run afoul in the TinkerPop >> side of things, so my personal inclination would be to close vote when >> posted and release. on the other hand, the vote closes on a saturday, which >> means that unless jason intends to do release work on the weekend, there's >> not much point to closing the vote on saturday and pieter can have some >> extra time. Anyway, I'll leave that up to Jason to coordinate with Ted as >> we traditionally release all our lines of code at once. Once they do close >> vote and release the artifacts, it will take up to 24 hours for apache >> infrastructure to sync the releases to all the mirrors, so everything is >> usually available the day after the vote closes. >> >> as for voting, every vote counts - though PMC votes are the ones that are >> technically "binding" for purpose of a release (in apache terms we need a >> "majority approval"[1] to put the release out the door). Now, if any vote, >> non-binding or binding came in as -1, we would take that fairly seriously, >> discuss it and depending on circumstances could scrap/delay the release. >> Testing releases and voting is an excellent and easy way to contribute to >> TinkerPop. >> >> [1] http://apache.org/foundation/glossary.html#MajorityApproval >> >> >> On Fri, Feb 10, 2017 at 8:47 AM, Paul A. Jackson <paul.jack...@pb.com> >> wrote: >> >>> I'm looking for some insight for when 3.2.4 will release. It looks like >>> voting closes tomorrow. Is that on schedule, and if so what's a typical >> ETA >>> for binaries to be posted? >>> >>> I don't know if my vote counts, but FTW! >>> >>> VOTE: +1 >>> >>> Thanks, >>> -Paul >>> >>> >>> -----Original Message----- >>> From: Stephen Mallette [mailto:spmalle...@gmail.com] >>> Sent: Friday, February 10, 2017 7:03 AM >>> To: dev@tinkerpop.apache.org >>> Subject: Re: [VOTE] TinkerPop 3.2.4 Release >>> >>> validate-distribution.sh was good for me - thanks for doing all the work >>> on this one Jason. nice job >>> >>> VOTE: +1 >>> >>> On Fri, Feb 10, 2017 at 1:22 AM, Ted Wilmes <twil...@gmail.com> wrote: >>> >>>> Release and docs looks good to me. >>>> >>>> Validating source distribution >>>> >>>> * downloading Apache TinkerPop 3.2.4 (apache-tinkerpop-3.2.4-src. >> zip)... >>>> OK >>>> * validating signatures and checksums ... >>>> * PGP signature ... OK >>>> * MD5 checksum ... OK >>>> * SHA1 checksum ... OK >>>> * unzipping Apache TinkerPop 3.2.4 ... OK >>>> * building project ... OK >>>> >>>> >>>> VOTE: +1 >>>> >>>> Thanks, >>>> Ted >>>> >>>> On Thu, Feb 9, 2017 at 12:32 PM, pieter-gmail >>>> <pieter.mar...@gmail.com> >>>> wrote: >>>> >>>>> Ok, however I did test on the 3.2.4-SNAPSHOT immediately after >>>>> Jason's email on the 2/2/2017 and those changes were not there. >>>>> They are there now but there was a SNAPSHOT release on the >>>>> 08/02/2017 so things changed. >>>>> Anyhow that might just be some SNAPSHOT confusion thing. >>>>> >>>>> Next time I'll pull the code and build it manually to make sure. >>>>> >>>>> Thanks >>>>> Pieter >>>>> >>>>> >>>>> >>>>> On 09/02/2017 22:27, Marko Rodriguez wrote: >>>>>> Hi, >>>>>> >>>>>>> The significant change is >>>>>>> ffe1b4c Marko A. Rodriguez <okramma...@gmail.com> on 2016/11/15 >>>>>>> at >>>>> 12:44 AM >>>>>> Ah yea. Thats different from what I thought you had issue with — >>>>> has-containers and arrays/collections handling. >>>>>>> I don't have a problem with the changes just that is quite a >>>>>>> refactor >>>> on >>>>>>> my side as it changes the structure of the HasSteps and its >>>>>>> HasContainers. I had made some assumptions around how HasSteps >>>>>>> and HasContainers look when optimizing. >>>>>> Yea, it “folds left” now so you don’t have to walk over >> has()-chains. >>>>>>> The change is quite old but somehow it was not present in the >>>>>>> 3.2.4-SNAPSHOT I tested on it when the code freeze announcement >>>>>>> was made. Not sure what happened there but alas its not giving me >>>>>>> enough time to get things working again. >>>>>> I would say don’t wait till releases to test Sqlg. In principle, >>>>>> you >>>>> should VOTE on every PR by building and testing the changes against >>> Sqlg. >>>>> That is where you can make a huge contribution. >>>>>>> So I am not voting negative just requesting a weekend, if >>>>>>> possible, to get through the refactor. >>>>>> Again, PR awareness, not release awareness. >>>>>> >>>>>> Marko. >>>>>> >>>>>> http://markorodriguez.com >>>>>> >>>>>> >>>>>>> Cheers >>>>>>> Pieter >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> "added TraversalHelper.addHasContainer() on 2016/11/15 >>>>>>> >>>>>>> On 09/02/2017 22:11, Stephen Mallette wrote: >>>>>>>> Unless I'm missing something, HasStep hasn't changed in 4 months >>>>>>>> and HasContainer hasn't changed in 3 months. The only update >>>>>>>> that went in >>>>> after >>>>>>>> 2/2 that I can think of that would have any bearing for graph >>>>> providers who >>>>>>>> tested before/after that date would be the AutoCloseable stuff: >>>>>>>> >>>>>>>> https://github.com/apache/tinkerpop/pull/548 >>>>>>>> >>>>>>>> Your problems aren't related to that are they? Can you provide >>>>>>>> some synopsis of where the problems lie? >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Feb 9, 2017 at 2:47 PM, pieter-gmail < >>>> pieter.mar...@gmail.com> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Some issues regarding the release process. >>>>>>>>> >>>>>>>>> On the 2/2/2017 the 3.2.4-SNAPSHOT was released. >>>>>>>>> I then started testing and found almost no issues. >>>>>>>>> >>>>>>>>> However yesterday when the VOTE mail came I found many issues >>>>>>>>> on >>>>> 3.2.4. >>>>>>>>> To understand the confusion I tested again on 3.2.4-SNAPSHOT >>>>>>>>> and >>>> found >>>>>>>>> the same new issues. >>>>>>>>> I then checked the 3.2.4-SNAPSHOT timestamp and it changed to >>>>> 08/02/2017 >>>>>>>>> Not sure what happened there as I can not, nor is it worth it, >>>>>>>>> check >>>>> an >>>>>>>>> old SNAPSHOT version's binary. >>>>>>>>> The relevant code changes are quite old (December 2016) but it >>>>>>>>> may >>>>> have >>>>>>>>> been done on a separate branch and rebasing may loose the >>>>>>>>> merging information. Not sure about this though. >>>>>>>>> >>>>>>>>> This only leaves the 72 hours to catch up. >>>>>>>>> >>>>>>>>> Even though it is a minor release there has been significant >>>>>>>>> changes >>>>> to >>>>>>>>> HasStep and HasContainer which breaks the heart (mine at least) >>>>>>>>> of implementors optimization code. >>>>>>>>> >>>>>>>>> Basically to get any value from a vote I for one will need more >>>> time. >>>>>>>>> So far I have not found any TinkerPop issues but will need at >>>>>>>>> least >>>>> the >>>>>>>>> weekend to know better. >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> Pieter >>>>>>>>> >>>>>>>>> On 08/02/2017 16:51, Jason Plurad wrote: >>>>>>>>>> Hello, >>>>>>>>>> >>>>>>>>>> We are happy to announce that TinkerPop 3.2.4 is ready for >>> release. >>>>>>>>>> The release artifacts can be found at this location: >>>>>>>>>> https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.4/ >>>>>>>>>> >>>>>>>>>> The source distribution is provided by: >>>>>>>>>> apache-tinkerpop-3.2.4-src.zip >>>>>>>>>> >>>>>>>>>> Two binary distributions are provided for user convenience: >>>>>>>>>> apache-tinkerpop-gremlin-console-3.2.4-bin.zip >>>>>>>>>> apache-tinkerpop-gremlin-server-3.2.4-bin.zip >>>>>>>>>> >>>>>>>>>> The GPG key used to sign the release artifacts is available at: >>>>>>>>>> https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS >>>>>>>>>> >>>>>>>>>> The online docs can be found here: >>>>>>>>>> http://tinkerpop.apache.org/docs/3.2.4/ (user docs) >>>>>>>>>> http://tinkerpop.apache.org/docs/3.2.4/upgrade/ >>>>>>>>>> (upgrade >>>>> docs) >>>>>>>>>> http://tinkerpop.apache.org/javadocs/3.2.4/core/ (core >>>>> javadoc) >>>>>>>>>> http://tinkerpop.apache.org/javadocs/3.2.4/full/ (full >>>>> javadoc) >>>>>>>>>> The tag in Apache Git can be found here: >>>>>>>>>> >>>>>>>>>> https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a= >>>>>>>>> tag;h=refs/tags/3.2.4 >>>>>>>>>> The release notes are available here: >>>>>>>>>> >>>>>>>>>> https://github.com/apache/tinkerpop/blob/3.2.4/ >>>>>>>>> CHANGELOG.asciidoc#release-3-2-4 >>>>>>>>>> The [VOTE] will be open for the next 72 hours --- closing >>>>>>>>>> Saturday (February 11, 2017) at 10:00 AM EST. >>>>>>>>>> >>>>>>>>>> My vote is +1. >>>>>>>>>> >>>>>>>>>> Thank you very much, >>>>>>>>>> Jason Plurad >>>>>>>>>> >>>>> >>> ________________________________ >>> >>>
