Re: [Discussed] Integrating SPARQL-Gremlin 0.2 Plugin with the TinkerPop codebase

2017-12-18 Thread Stephen Mallette
> Should I also remove the northwind file? I think I'd prefer to see all of our sparql examples use the existing toy graphs - better not to add more options - so I'd remove it as well. If anyone disagrees, I don't really feel too strongly about not including it, but it would be good to hear some r

[Discussed] Integrating SPARQL-Gremlin 0.2 Plugin with the TinkerPop codebase

2017-12-18 Thread Harsh Thakkar
Hello Stephen, Alright, I will remove the bsbm file from the repository and I refer to it in the docs (with some examples) sharing a link to download from the website if that is acceptable. No worries. Should I also remove the northwind file? Your expectations are reasonable, it was just tha

Re: [Discussed] Integrating SPARQL-Gremlin 0.2 Plugin with the TinkerPop codebase

2017-12-18 Thread Harsh Thakkar
Hello Marko, I made a mistake mentioning earlier that the sparql-gremlin compiler returns a string, well it does not. It returns a graph traversal, apologies! Regarding (7), I agree, it makes sense. I will wrap my head around how to get that done. I am already reading the dev-docs on this, from

Re: [VOTE] TinkerPop 3.3.1 Release

2017-12-18 Thread Daniel Kuppitz
/projects/apache/tinkerpop (master) $ bin/validate-distribution.sh 3.3.1 Validating binary distributions * downloading Apache TinkerPop Gremlin (apache-tinkerpop-gremlin-console-3.3.1-bin.zip)... OK * validating signatures and checksums ... * PGP signature ... OK * MD5 checksum ... OK * SHA

Re: [VOTE] TinkerPop 3.2.7 Release

2017-12-18 Thread Daniel Kuppitz
/projects/apache/tinkerpop (tp32) $ bin/validate-distribution.sh 3.2.7 Validating binary distributions * downloading Apache TinkerPop Gremlin (apache-tinkerpop-gremlin-console-3.2.7-bin.zip)... OK * validating signatures and checksums ... * PGP signature ... OK * MD5 checksum ... OK * SHA1

Re: [Discussed] Integrating SPARQL-Gremlin 0.2 Plugin with the TinkerPop codebase

2017-12-18 Thread Stephen Mallette
A quick note about (4) - Having some sample data for user convenience is good. Files like that though should not be "resources", but should be added here: https://github.com/harsh9t/tinkerpop/tree/master/data Placing those files there will allow them to be included in the the .zip distribution fi

[jira] [Commented] (TINKERPOP-1855) Update Rexster links

2017-12-18 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295458#comment-16295458 ] stephen mallette commented on TINKERPOP-1855: - nvm - i'm seeing what you'r

[jira] [Commented] (TINKERPOP-1855) Update Rexster links

2017-12-18 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295454#comment-16295454 ] stephen mallette commented on TINKERPOP-1855: - I don't think any of the ol

Re: [VOTE] TinkerPop 3.2.7 Release

2017-12-18 Thread Robert Dale
I have some minor link fixes to merge after the release. VOTE +1 Robert Dale On Mon, Dec 18, 2017 at 3:37 AM, Jorge Bay Gondra wrote: > VOTE: +1 > > On Sun, Dec 17, 2017 at 11:04 PM, David Brown wrote: > > > docker/build.sh -t -i -n > > > > [INFO] BUILD SUCCESS > > [INFO] -

Re: [VOTE] TinkerPop 3.3.1 Release

2017-12-18 Thread Robert Dale
I have some minor link fixes to merge after the release. VOTE +1 Robert Dale On Mon, Dec 18, 2017 at 3:37 AM, Jorge Bay Gondra wrote: > VOTE +1 > > On Sun, Dec 17, 2017 at 10:37 PM, Michael Pollmeier < > mich...@michaelpollmeier.com> wrote: > > > Thanks Stephen! > > > > I upgraded gremlin-scala

Re: [Discussed] Integrating SPARQL-Gremlin 0.2 Plugin with the TinkerPop codebase

2017-12-18 Thread Marko Rodriguez
Actually, my (3) is bad. Given that query() would always return a Traversal>, it would be necessary to have that linearized to Traversal for the test suite to validate it. That would mean making SPARQLTraversal support extended Traversal methods like flatMap(), blah, blah… That seems excessive,

[jira] [Created] (TINKERPOP-1855) Update Rexster links

2017-12-18 Thread Robert Dale (JIRA)
Robert Dale created TINKERPOP-1855: -- Summary: Update Rexster links Key: TINKERPOP-1855 URL: https://issues.apache.org/jira/browse/TINKERPOP-1855 Project: TinkerPop Issue Type: Bug

Re: [Discussed] Integrating SPARQL-Gremlin 0.2 Plugin with the TinkerPop codebase

2017-12-18 Thread Marko Rodriguez
Hello, A couple of items worth considering. Regarding (7), that should be done prior to master/ merge. It is necessary to follow the patterns that are established in TinkerPop regarding language interoperability. The DSL pattern developed for Gremlin language variants seems to be the best patt

Re: [Discussed] Integrating SPARQL-Gremlin 0.2 Plugin with the TinkerPop codebase

2017-12-18 Thread Harsh Thakkar
Hi Stephen and All, Thanks for going through the code. I address your questions below (in the same order): 1. Yes, this file can be removed. It was just to test the traversal method. 2. Yes, I have commented out the block of tests at this moment since we do not need to run tests at mvn clean

Re: [Discussed] Integrating SPARQL-Gremlin 0.2 Plugin with the TinkerPop codebase

2017-12-18 Thread Stephen Mallette
Harsh, I looked at the code in a bit more detail than I have. Here's some thoughts/questions I had as I was going through things: 1. Can this file be removed - it doesn't appear to have any usage that I can see: https://github.com/harsh9t/tinkerpop/blob/master/sparql-gremlin/src/main/java/org/apa

Re: [VOTE] TinkerPop 3.3.1 Release

2017-12-18 Thread Jorge Bay Gondra
VOTE +1 On Sun, Dec 17, 2017 at 10:37 PM, Michael Pollmeier < mich...@michaelpollmeier.com> wrote: > Thanks Stephen! > > I upgraded gremlin-scala, no issues. > https://github.com/mpollmeier/gremlin-scala/tree/michael/tp3.3.1 > > vote +1 > > Michael > > > On 18/12/17 05:54, Stephen Mallette wrote:

Re: [VOTE] TinkerPop 3.2.7 Release

2017-12-18 Thread Jorge Bay Gondra
VOTE: +1 On Sun, Dec 17, 2017 at 11:04 PM, David Brown wrote: > docker/build.sh -t -i -n > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 3:56:54.392s > [INFO] Finished at: Sun Dec 17 21:40:30 UTC 2017 > [INFO] Fin