[jira] [Commented] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH

2018-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325728#comment-16325728 ] ASF GitHub Bot commented on TINKERPOP-1862: --- Github user PBGraff commented o

[GitHub] tinkerpop issue #777: TINKERPOP-1862 TinkerMessenger proper handling of Dire...

2018-01-14 Thread PBGraff
Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/777 Tests pass now, good to go from me. ---

[jira] [Commented] (TINKERPOP-1861) VertexProgram create with varargs for Graphs

2018-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325701#comment-16325701 ] ASF GitHub Bot commented on TINKERPOP-1861: --- Github user PBGraff commented o

[GitHub] tinkerpop issue #772: TINKERPOP-1861 Modify VertexProgram Builder to take va...

2018-01-14 Thread PBGraff
Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/772 I think all test problems have now been fixed. My concern is that people may still override/implement the old method and not the new one, thus yielding programs that don't execute properly. It wil

[GitHub] tinkerpop pull request #774: TINKERPOP-1860 valueMap(true) support/testing

2018-01-14 Thread FlorianHockmann
Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/774#discussion_r161403447 --- Diff: gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs --- @@ -236,6 +237,11 @@ private static object ToLambda(string st

[jira] [Commented] (TINKERPOP-1860) valueMap(True) result in error in gremlin-python

2018-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325671#comment-16325671 ] ASF GitHub Bot commented on TINKERPOP-1860: --- Github user FlorianHockmann com

[jira] [Commented] (TINKERPOP-1868) Support inject source step in Gremlin.Net

2018-01-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325567#comment-16325567 ] ASF GitHub Bot commented on TINKERPOP-1868: --- Github user FlorianHockmann com

[GitHub] tinkerpop issue #776: TINKERPOP-1868 Gremlin.Net: Add Inject step to GraphTr...

2018-01-14 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/776 ``` $ docker/build.sh -t -i [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop .

Re: [DISCUSS] TinkerGraph Memory Usage Enhancements

2018-01-14 Thread Michael Pollmeier
First of all: if you're not manually enabling the memory-efficient mode, you get the exact same behaviour as now. With the memory-efficient mode enabled, a few semantics change (by design): * setting a property that is not schema-conform may (IMO *should*, but that depends on the implementation) t