Re: [DISCUSS] Contributor vs Developer

2018-01-24 Thread Robert Dale
I think just leave alone. If anyone feels like they need to be recognized, they can include a in their PR. Robert Dale On Wed, Jan 24, 2018 at 5:01 PM, Stephen Mallette wrote: > I've read that before. Considering the rule of thumb > > > A good rule of thumb is, if the person should not be co

[GitHub] tinkerpop pull request #790: TINKERPOP-1875 Gremlin-Python only aggregates t...

2018-01-24 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/790#discussion_r163694635 --- Diff: gremlin-python/src/main/jython/tests/conftest.py --- @@ -65,10 +65,14 @@ def fin(): request.addfinalizer(fin) return

[jira] [Commented] (TINKERPOP-1875) Gremlin-Python only aggregates to list when using GraphSON3

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338313#comment-16338313 ] ASF GitHub Bot commented on TINKERPOP-1875: --- Github user spmallette commente

[jira] [Commented] (TINKERPOP-1870) n^2 synchronious operation in OLAP WorkerExecutor.execute() method

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338305#comment-16338305 ] ASF GitHub Bot commented on TINKERPOP-1870: --- Github user asfgit closed the p

[GitHub] tinkerpop pull request #789: TINKERPOP-1870 Made VertexTraverserSet more gen...

2018-01-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/789 ---

[jira] [Closed] (TINKERPOP-1870) n^2 synchronious operation in OLAP WorkerExecutor.execute() method

2018-01-24 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1870. --- Resolution: Implemented > n^2 synchronious operation in OLAP WorkerExecutor.execut

Re: [DISCUSS] Contributor vs Developer

2018-01-24 Thread Stephen Mallette
I've read that before. Considering the rule of thumb > A good rule of thumb is, if the person should not be contacted about the project, they need not be listed here. how do you interpret that rule (plus the rest of what's written there) with respect to people who have specific expertise in just

Re: [DISCUSS] Contributor vs Developer

2018-01-24 Thread Robert Dale
https://maven.apache.org/pom.html#Developers Robert Dale On Wed, Jan 24, 2018 at 3:23 PM, Stephen Mallette wrote: > Does anyone have any opinion on how the pom.xml tags and > are used? > > https://github.com/apache/tinkerpop/blob/3.3.1/pom.xml#L58-L111 > > I don't think we have really kept t

[jira] [Commented] (TINKERPOP-1875) Gremlin-Python only aggregates to list when using GraphSON3

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338246#comment-16338246 ] ASF GitHub Bot commented on TINKERPOP-1875: --- GitHub user davebshow opened a

[GitHub] tinkerpop pull request #790: TINKERPOP-1875 Gremlin-Python only aggregates t...

2018-01-24 Thread davebshow
GitHub user davebshow opened a pull request: https://github.com/apache/tinkerpop/pull/790 TINKERPOP-1875 Gremlin-Python only aggregates to list when using GraphSON3 https://issues.apache.org/jira/browse/TINKERPOP-1875 This PR fixes server response message deserialization in

[jira] [Commented] (TINKERPOP-1870) n^2 synchronious operation in OLAP WorkerExecutor.execute() method

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338240#comment-16338240 ] ASF GitHub Bot commented on TINKERPOP-1870: --- Github user robertdale commente

[GitHub] tinkerpop issue #789: TINKERPOP-1870 Made VertexTraverserSet more generic to...

2018-01-24 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/789 VOTE +1 ---

[jira] [Commented] (TINKERPOP-1870) n^2 synchronious operation in OLAP WorkerExecutor.execute() method

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338226#comment-16338226 ] ASF GitHub Bot commented on TINKERPOP-1870: --- Github user dkuppitz commented

[GitHub] tinkerpop issue #789: TINKERPOP-1870 Made VertexTraverserSet more generic to...

2018-01-24 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/789 VOTE: +1 ---

Re: [Discussed] Integrating SPARQL-Gremlin 0.2 Plugin with the TinkerPop codebase

2018-01-24 Thread Stephen Mallette
I just wanted to quickly note that sparql-gremlin is now building properly on the TINKERPOP-1878 branch (i just pushed some changes to clean up some pom.xml/dependency conflicts issues). As we discussed in this thread, the branch currently contains a fairly bare bones model and it will need some wo

[DISCUSS] Contributor vs Developer

2018-01-24 Thread Stephen Mallette
Does anyone have any opinion on how the pom.xml tags and are used? https://github.com/apache/tinkerpop/blob/3.3.1/pom.xml#L58-L111 I don't think we have really kept these sections up to date or have any kind of consistency in terms of who ends under which section. Should we just say that is f

[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337991#comment-16337991 ] ASF GitHub Bot commented on TINKERPOP-1489: --- Github user spmallette commente

[GitHub] tinkerpop issue #695: TINKERPOP-1489 JavaScript GLV

2018-01-24 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/695 All tests pass with `docker/build.sh -t -n -i` VOTE +1 ---

[jira] [Commented] (TINKERPOP-1870) n^2 synchronious operation in OLAP WorkerExecutor.execute() method

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337605#comment-16337605 ] ASF GitHub Bot commented on TINKERPOP-1870: --- Github user artem-aliev comment

[GitHub] tinkerpop issue #789: TINKERPOP-1870 Made VertexTraverserSet more generic to...

2018-01-24 Thread artem-aliev
Github user artem-aliev commented on the issue: https://github.com/apache/tinkerpop/pull/789 +1 I reran my small perf test and get the same result with this new structure, but it looks more solid and inline with other code. ---

[jira] [Commented] (TINKERPOP-1874) P does not appear to be serialized consistently in GraphSON

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337588#comment-16337588 ] ASF GitHub Bot commented on TINKERPOP-1874: --- Github user spmallette commente

[GitHub] tinkerpop issue #784: TINKERPOP-1874 P does not appear to be serialized cons...

2018-01-24 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/784 Here's the follow up fixes given the comments: https://github.com/apache/tinkerpop/commit/d5b6ebb08229be07761d11c3a4065f21a8dcddd3 ---

[jira] [Commented] (TINKERPOP-1874) P does not appear to be serialized consistently in GraphSON

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337566#comment-16337566 ] ASF GitHub Bot commented on TINKERPOP-1874: --- Github user asfgit closed the p

[jira] [Commented] (TINKERPOP-1874) P does not appear to be serialized consistently in GraphSON

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337567#comment-16337567 ] ASF GitHub Bot commented on TINKERPOP-1874: --- Github user asfgit closed the p

[jira] [Closed] (TINKERPOP-1874) P does not appear to be serialized consistently in GraphSON

2018-01-24 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1874. --- Resolution: Fixed Fix Version/s: 3.3.2 3.2.8 > P does no

[GitHub] tinkerpop pull request #785: TINKERPOP-1874 master

2018-01-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/785 ---

[GitHub] tinkerpop pull request #784: TINKERPOP-1874 P does not appear to be serializ...

2018-01-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/784 ---

[GitHub] tinkerpop issue #786: TINKERPOP-1873 min() and max() work only in the range ...

2018-01-24 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/786 VOTE +1 ---

[jira] [Commented] (TINKERPOP-1873) min() and max() work only in the range of Integer values

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337553#comment-16337553 ] ASF GitHub Bot commented on TINKERPOP-1873: --- Github user robertdale commente

[jira] [Commented] (TINKERPOP-1874) P does not appear to be serialized consistently in GraphSON

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337545#comment-16337545 ] ASF GitHub Bot commented on TINKERPOP-1874: --- Github user robertdale commente

[GitHub] tinkerpop issue #784: TINKERPOP-1874 P does not appear to be serialized cons...

2018-01-24 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/784 VOTE +1 ---

[jira] [Commented] (TINKERPOP-1874) P does not appear to be serialized consistently in GraphSON

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337515#comment-16337515 ] ASF GitHub Bot commented on TINKERPOP-1874: --- Github user spmallette commente

[GitHub] tinkerpop issue #784: TINKERPOP-1874 P does not appear to be serialized cons...

2018-01-24 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/784 I will clean up all of @robertdale "no/not" stuff when i merge. ---

[jira] [Commented] (TINKERPOP-1874) P does not appear to be serialized consistently in GraphSON

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337481#comment-16337481 ] ASF GitHub Bot commented on TINKERPOP-1874: --- Github user spmallette commente

[jira] [Commented] (TINKERPOP-1874) P does not appear to be serialized consistently in GraphSON

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337479#comment-16337479 ] ASF GitHub Bot commented on TINKERPOP-1874: --- Github user robertdale commente

[jira] [Commented] (TINKERPOP-1874) P does not appear to be serialized consistently in GraphSON

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337478#comment-16337478 ] ASF GitHub Bot commented on TINKERPOP-1874: --- Github user robertdale commente

[jira] [Commented] (TINKERPOP-1874) P does not appear to be serialized consistently in GraphSON

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337480#comment-16337480 ] ASF GitHub Bot commented on TINKERPOP-1874: --- Github user robertdale commente

[jira] [Commented] (TINKERPOP-1874) P does not appear to be serialized consistently in GraphSON

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337477#comment-16337477 ] ASF GitHub Bot commented on TINKERPOP-1874: --- Github user spmallette commente

[GitHub] tinkerpop pull request #784: TINKERPOP-1874 P does not appear to be serializ...

2018-01-24 Thread robertdale
Github user robertdale commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/784#discussion_r163529404 --- Diff: docs/src/dev/io/graphson.asciidoc --- @@ -4066,11 +4075,12 @@ The following `RequestMessage` is an example of a sessionless request for a scr

[GitHub] tinkerpop pull request #784: TINKERPOP-1874 P does not appear to be serializ...

2018-01-24 Thread robertdale
Github user robertdale commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/784#discussion_r163529843 --- Diff: docs/src/dev/io/graphson.asciidoc --- @@ -187,8 +180,7 @@ file.withWriter { writer -> writer.write(toJson(msg, "Sessionless Eval", "The

[GitHub] tinkerpop pull request #784: TINKERPOP-1874 P does not appear to be serializ...

2018-01-24 Thread robertdale
Github user robertdale commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/784#discussion_r163529709 --- Diff: docs/src/dev/io/graphson.asciidoc --- @@ -75,8 +72,7 @@ file.withWriter { writer -> writer.write(toJson(msg, "Sessionless Eval", "The f

[GitHub] tinkerpop pull request #784: TINKERPOP-1874 P does not appear to be serializ...

2018-01-24 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/784#discussion_r163530149 --- Diff: docs/src/dev/io/graphson.asciidoc --- @@ -1279,7 +1270,7 @@ The following `RequestMessage` is an example of a sessionless request for a scri

[GitHub] tinkerpop pull request #784: TINKERPOP-1874 P does not appear to be serializ...

2018-01-24 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/784#discussion_r163530046 --- Diff: docs/src/dev/io/graphson.asciidoc --- @@ -3580,6 +3572,41 @@ The following `Bytecode` example represents the traversal of `g.V().hasLabel('pe

[jira] [Commented] (TINKERPOP-1874) P does not appear to be serialized consistently in GraphSON

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337469#comment-16337469 ] ASF GitHub Bot commented on TINKERPOP-1874: --- Github user robertdale commente

[GitHub] tinkerpop pull request #784: TINKERPOP-1874 P does not appear to be serializ...

2018-01-24 Thread robertdale
Github user robertdale commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/784#discussion_r163528577 --- Diff: docs/src/dev/io/graphson.asciidoc --- @@ -1279,7 +1270,7 @@ The following `RequestMessage` is an example of a sessionless request for a scri

[GitHub] tinkerpop issue #772: TINKERPOP-1861 Modify VertexProgram Builder to take va...

2018-01-24 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/772 Sorry - you really shouldnt have any commits from our repo in this PR - it should be all your work. The problem is that if when we look at the diff to review, it contains changes that don't pe

[jira] [Commented] (TINKERPOP-1861) VertexProgram create with varargs for Graphs

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337460#comment-16337460 ] ASF GitHub Bot commented on TINKERPOP-1861: --- Github user spmallette commente

[jira] [Commented] (TINKERPOP-1874) P does not appear to be serialized consistently in GraphSON

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337458#comment-16337458 ] ASF GitHub Bot commented on TINKERPOP-1874: --- Github user jorgebay commented

[GitHub] tinkerpop issue #784: TINKERPOP-1874 P does not appear to be serialized cons...

2018-01-24 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/784 I've added a small suggestion. Looks great, VOTE +1. ---

[jira] [Commented] (TINKERPOP-1874) P does not appear to be serialized consistently in GraphSON

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337457#comment-16337457 ] ASF GitHub Bot commented on TINKERPOP-1874: --- Github user jorgebay commented

[GitHub] tinkerpop pull request #784: TINKERPOP-1874 P does not appear to be serializ...

2018-01-24 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/784#discussion_r163525550 --- Diff: docs/src/dev/io/graphson.asciidoc --- @@ -3580,6 +3572,41 @@ The following `Bytecode` example represents the traversal of `g.V().hasLabel('pe

[jira] [Commented] (TINKERPOP-1870) n^2 synchronious operation in OLAP WorkerExecutor.execute() method

2018-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337420#comment-16337420 ] ASF GitHub Bot commented on TINKERPOP-1870: --- GitHub user spmallette opened a

[GitHub] tinkerpop pull request #789: TINKERPOP-1870 Made VertexTraverserSet more gen...

2018-01-24 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/789 TINKERPOP-1870 Made VertexTraverserSet more generic to IndexedTraverserSet https://issues.apache.org/jira/browse/TINKERPOP-1870 IndexedTraverserSet does what VertexTraverserSet was doi