Re: [DISCUSS] Deprecation around Java driver

2018-08-08 Thread Stephen Mallette
RequestOptions is specific to the driver implementation, but the class will allow you to add provider specific parameters as allowed by the Gremlin Server protocol itself. That's more than what was previously allowed by the way. If you had provider specific protocol level parameters the user would

Re: [DISCUSS] Deprecation around Java driver

2018-08-08 Thread Ted Wilmes
That sounds like a good approach. At this point, would you envision those being TP specific options or perhaps include include hooks to support arbitrary provider options? --Ted On Wed, Aug 8, 2018 at 1:00 PM Stephen Mallette wrote: > Allow the setting of the scriptEvaluationTimeout per request

[DISCUSS] Deprecation around Java driver

2018-08-08 Thread Stephen Mallette
Allow the setting of the scriptEvaluationTimeout per request has been an issue for a long time: https://issues.apache.org/jira/browse/TINKERPOP-1342 I've hesitated a number of times in implementing this as it seemed to mean just more overloads around submit() and I didn't really want that. I thin

[jira] [Updated] (TINKERPOP-1342) Allow setting scriptEvaluationTimeout in driver

2018-08-08 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1342: Labels: deprecation (was: ) I think that implementing this will require deprec

[GitHub] tinkerpop issue #908: TINKERPOP-2017 Add check for Column in `by(Function)`

2018-08-08 Thread twilmes
Github user twilmes commented on the issue: https://github.com/apache/tinkerpop/pull/908 Looks good @yura-ata. Did you re-target `master` again for a particular reason? VOTE: +1 ---

[jira] [Commented] (TINKERPOP-2017) Check for Column in by()

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573436#comment-16573436 ] ASF GitHub Bot commented on TINKERPOP-2017: --- Github user twilmes commented

[jira] [Commented] (TINKERPOP-1976) Include Computer tests for GLVs

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573423#comment-16573423 ] ASF GitHub Bot commented on TINKERPOP-1976: --- Github user FlorianHockmann co

[GitHub] tinkerpop issue #909: TINKERPOP-1976 GLV testing for computer tests

2018-08-08 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/909 Great to now also have the computer tests for the GLVs :tada: VOTE +1 ---

[jira] [Commented] (TINKERPOP-1976) Include Computer tests for GLVs

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573392#comment-16573392 ] ASF GitHub Bot commented on TINKERPOP-1976: --- Github user dkuppitz commented

[GitHub] tinkerpop issue #909: TINKERPOP-1976 GLV testing for computer tests

2018-08-08 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/909 VOTE: +1 ---

[jira] [Commented] (TINKERPOP-1990) Add a shortestPath() step

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573384#comment-16573384 ] ASF GitHub Bot commented on TINKERPOP-1990: --- Github user spmallette comment

[GitHub] tinkerpop issue #882: TINKERPOP-1990 Add a shortestPath() step

2018-08-08 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/882 Let's get #909 merged, rebase this, add GLV tests and then merge this one (doing the same for #897 ) ---

[jira] [Commented] (TINKERPOP-1976) Include Computer tests for GLVs

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573375#comment-16573375 ] ASF GitHub Bot commented on TINKERPOP-1976: --- GitHub user spmallette opened

[GitHub] tinkerpop pull request #909: Tinkerpop 1976

2018-08-08 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/909 Tinkerpop 1976 https://issues.apache.org/jira/browse/TINKERPOP-1976 Added GLV tests for `pageRank()` and `peerPressure()` (i.e. "computer" tests). Apparently we had good support for t

[jira] [Closed] (TINKERPOP-550) Gremlin IO needs to support both OLTP and OLAP naturally.

2018-08-08 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-550. -- Resolution: Done Assignee: stephen mallette Fix Version/s: 3.4.0 Com

[jira] [Commented] (TINKERPOP-1991) Generalized DSL in GLVs

2018-08-08 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573098#comment-16573098 ] stephen mallette commented on TINKERPOP-1991: - Hmm - I'm suddenly realizi

[jira] [Created] (TINKERPOP-2021) Prevent maximum recursion depth failure

2018-08-08 Thread stephen mallette (JIRA)
stephen mallette created TINKERPOP-2021: --- Summary: Prevent maximum recursion depth failure Key: TINKERPOP-2021 URL: https://issues.apache.org/jira/browse/TINKERPOP-2021 Project: TinkerPop

Re: [Discussed] Integrating SPARQL-Gremlin 0.2 Plugin with the TinkerPop codebase

2018-08-08 Thread Stephen Mallette
I thought I had brought attention to this on a different thread somewhere along the line, but note that the sparql-gremlin PR has been out there long enough now that it can be merged on my +1 plus lazy consensus: https://github.com/apache/tinkerpop/pull/902 I'll leave it open a bit longer in case

[jira] [Commented] (TINKERPOP-2017) Check for Column in by()

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573033#comment-16573033 ] ASF GitHub Bot commented on TINKERPOP-2017: --- Github user spmallette comment

[GitHub] tinkerpop issue #908: TINKERPOP-2017 Add check for Column in `by(Function)`

2018-08-08 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/908 VOTE +1 ---