[GitHub] tinkerpop issue #868: Tinkerpop 1913

2018-08-10 Thread ashwini-mnnit
Github user ashwini-mnnit commented on the issue: https://github.com/apache/tinkerpop/pull/868 @spmallette, I apologies for the delay. I lost the 2 factor auth for my official account (lost phone authentication) . I am trying to recover the account. I will close on this soon. ---

Re: [DISCUSS] Security should be secure by default

2018-08-10 Thread Robert Dale
Actually, I was thinking of adding those to just the server. The server usually dictates the security requirements. But we could add it to the client as well. I think it makes sense to keep them symmetric. Robert Dale On Fri, Aug 10, 2018 at 2:43 PM kARTHIK R wrote: > Both proposals look

[jira] [Commented] (TINKERPOP-1878) Sparql to Gremlin Compiler

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576759#comment-16576759 ] ASF GitHub Bot commented on TINKERPOP-1878: --- Github user spmallette commented on a diff in

[GitHub] tinkerpop pull request #902: TINKERPOP-1878 sparql-gremlin

2018-08-10 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/902#discussion_r209362047 --- Diff: sparql-gremlin/src/main/java/org/apache/tinkerpop/gremlin/sparql/process/traversal/dsl/sparql/SparqlTraversalSource.java --- @@ -0,0 +1,155

[DISCUSS] Options for withRemote()

2018-08-10 Thread Stephen Mallette
I've never been quite settled on how to connect to remote graphs. For a while we had RemoteGraph but that wasn't useful really because it was largely non-functional, as you really just needed a remote configured TraversalSource - so we deprecated that. TraversalSource.withRemote() is fine, but you

Re: [DISCUSS] Security should be secure by default

2018-08-10 Thread kARTHIK R
Both proposals look good, if we are making a backwards incompatible change, then it makes sense to clean it up and address other issues around that space. Limiting cipherSuites and TLS versions -> Are you planning to add those settings to Gremlin Server as well, or just on the client? Is this

[GitHub] tinkerpop pull request #842: TINKERPOP-1945

2018-08-10 Thread FlorianHockmann
Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/842#discussion_r209342928 --- Diff: gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONWriterTests.cs --- @@ -346,6 +347,70 @@ public void

[jira] [Commented] (TINKERPOP-1945) Add support for extended GraphSon types to Gremlin.net

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576691#comment-16576691 ] ASF GitHub Bot commented on TINKERPOP-1945: --- Github user FlorianHockmann commented on a

[GitHub] tinkerpop pull request #842: TINKERPOP-1945

2018-08-10 Thread FlorianHockmann
Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/842#discussion_r209346542 --- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphSON/TimeSpanDeserializer.cs --- @@ -0,0 +1,37 @@ +#region License + +/*

[GitHub] tinkerpop pull request #902: TINKERPOP-1878 sparql-gremlin

2018-08-10 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/902#discussion_r209347298 --- Diff: docs/site/home/index.html --- @@ -259,6 +259,7 @@ Query Languages

[jira] [Commented] (TINKERPOP-1878) Sparql to Gremlin Compiler

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576689#comment-16576689 ] ASF GitHub Bot commented on TINKERPOP-1878: --- Github user spmallette commented on a diff in

[jira] [Commented] (TINKERPOP-1878) Sparql to Gremlin Compiler

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576687#comment-16576687 ] ASF GitHub Bot commented on TINKERPOP-1878: --- Github user dkuppitz commented on a diff in

[jira] [Commented] (TINKERPOP-1878) Sparql to Gremlin Compiler

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576685#comment-16576685 ] ASF GitHub Bot commented on TINKERPOP-1878: --- Github user dkuppitz commented on a diff in

[jira] [Commented] (TINKERPOP-1878) Sparql to Gremlin Compiler

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576686#comment-16576686 ] ASF GitHub Bot commented on TINKERPOP-1878: --- Github user dkuppitz commented on a diff in

[GitHub] tinkerpop pull request #902: TINKERPOP-1878 sparql-gremlin

2018-08-10 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/902#discussion_r209334263 --- Diff: docs/site/home/index.html --- @@ -259,6 +259,7 @@ Query Languages

[GitHub] tinkerpop pull request #902: TINKERPOP-1878 sparql-gremlin

2018-08-10 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/902#discussion_r209336628 --- Diff: docs/src/reference/compilers.asciidoc --- @@ -0,0 +1,416 @@ + +Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] tinkerpop pull request #902: TINKERPOP-1878 sparql-gremlin

2018-08-10 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/902#discussion_r209346676 --- Diff: sparql-gremlin/src/main/java/org/apache/tinkerpop/gremlin/sparql/process/traversal/dsl/sparql/SparqlTraversalSource.java --- @@ -0,0 +1,155

[jira] [Updated] (TINKERPOP-1838) Python sample project

2018-08-10 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1838: Priority: Trivial (was: Minor) > Python sample project >

[jira] [Closed] (TINKERPOP-1951) gremlin-server.bat doesn't support paths containing spaces

2018-08-10 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1951. --- Resolution: Fixed Assignee: stephen mallette Fix Version/s:

[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576472#comment-16576472 ] ASF GitHub Bot commented on TINKERPOP-1822: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #838: TINKERPOP-1822: Change default RepeatStep to DFS

2018-08-10 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/838 @krlohnes not sure if you're still thinking about this one, but if you are and you get a chance, could you please rebase your branch to freshen things up a bit? ---

[GitHub] tinkerpop issue #903: Gremlin.Net: Add ConnectionPool min and max sizes TINK...

2018-08-10 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/903 VOTE +1 ---

[jira] [Commented] (TINKERPOP-1774) Gremlin .NET: Support min and max sizes in Connection pool

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576469#comment-16576469 ] ASF GitHub Bot commented on TINKERPOP-1774: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop pull request #905: Pr 891

2018-08-10 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/905#discussion_r209302881 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLWriter.java --- @@ -18,6 +18,21 @@ */

[jira] [Closed] (TINKERPOP-1672) Use python-style syntax for YAML configuration files

2018-08-10 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1672. --- Resolution: Won't Do Assignee: (was: Jean-Baptiste Musso) I took a

[jira] [Closed] (TINKERPOP-1990) Add a shortestPath() step

2018-08-10 Thread Daniel Kuppitz (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Kuppitz closed TINKERPOP-1990. - Resolution: Fixed Fix Version/s: 3.4.0 > Add a shortestPath() step >

[jira] [Commented] (TINKERPOP-1990) Add a shortestPath() step

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576345#comment-16576345 ] ASF GitHub Bot commented on TINKERPOP-1990: --- Github user asfgit closed the pull request at:

[GitHub] tinkerpop pull request #882: TINKERPOP-1990 Add a shortestPath() step

2018-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/882 ---

[jira] [Commented] (TINKERPOP-1990) Add a shortestPath() step

2018-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576341#comment-16576341 ] ASF GitHub Bot commented on TINKERPOP-1990: --- Github user spmallette commented on the issue:

[GitHub] tinkerpop issue #882: TINKERPOP-1990 Add a shortestPath() step

2018-08-10 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/882 VOTE +1 ---