[GitHub] tinkerpop pull request #916: Update comments in GraphProvider clear() and op...

2018-08-20 Thread justinchuch
GitHub user justinchuch opened a pull request: https://github.com/apache/tinkerpop/pull/916 Update comments in GraphProvider clear() and openTestGraph() What's changed: Classes that have implemented `GraphProvider#clear` must note that the parameter `graph` and `config` are

[jira] [Commented] (TINKERPOP-2023) Gremlin Server should not create self-signed certs

2018-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586280#comment-16586280 ] ASF GitHub Bot commented on TINKERPOP-2023: --- Github user robertdale comment

[GitHub] tinkerpop issue #912: TINKERPOP-2023 SSL Enhancements

2018-08-20 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/912 @k4rthikr That's a little deeper than I want to get into. `sslCipherSuites` provides a whitelist. Whitelists are always preferred over blacklists. If this one were blacklisted, there are probab

[jira] [Commented] (TINKERPOP-2023) Gremlin Server should not create self-signed certs

2018-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586194#comment-16586194 ] ASF GitHub Bot commented on TINKERPOP-2023: --- Github user k4rthikr commented

[GitHub] tinkerpop issue #912: TINKERPOP-2023 SSL Enhancements

2018-08-20 Thread k4rthikr
Github user k4rthikr commented on the issue: https://github.com/apache/tinkerpop/pull/912 @robertdale Should we also provide a config entry for disabling certain cipher suites? For example TLS_RSA_WITH_3DES_EDE_CBC_SHA is supported. This cipher suite has a 64-bit block size, and the s

[jira] [Commented] (TINKERPOP-2023) Gremlin Server should not create self-signed certs

2018-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586080#comment-16586080 ] ASF GitHub Bot commented on TINKERPOP-2023: --- Github user FlorianHockmann co

[GitHub] tinkerpop issue #912: TINKERPOP-2023 SSL Enhancements

2018-08-20 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/912 > They settings are @Deprecated not removed - for example: Ah, thanks for the clarification. I indeed only looked at the changes to the docs. Deprecating those settings is of cours

[jira] [Commented] (TINKERPOP-2023) Gremlin Server should not create self-signed certs

2018-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586075#comment-16586075 ] ASF GitHub Bot commented on TINKERPOP-2023: --- Github user spmallette comment

[GitHub] tinkerpop issue #912: TINKERPOP-2023 SSL Enhancements

2018-08-20 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/912 They settings are `@Deprecated` not removed - for example: https://github.com/apache/tinkerpop/pull/912/files#diff-45b18530a9a147f84ad0ee9ddab81fa1R681 once we deprecate someth

[jira] [Commented] (TINKERPOP-2023) Gremlin Server should not create self-signed certs

2018-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586070#comment-16586070 ] ASF GitHub Bot commented on TINKERPOP-2023: --- Github user FlorianHockmann co

[GitHub] tinkerpop issue #912: TINKERPOP-2023 SSL Enhancements

2018-08-20 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/912 To be honest, I haven't taken a detailed look at the changes of this PR yet, but it seems to also remove / rename a bunch of config properties like `ssl.keyFile` for example. Doesn't this

[jira] [Commented] (TINKERPOP-2023) Gremlin Server should not create self-signed certs

2018-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586061#comment-16586061 ] ASF GitHub Bot commented on TINKERPOP-2023: --- Github user spmallette comment

[GitHub] tinkerpop issue #912: TINKERPOP-2023 SSL Enhancements

2018-08-20 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/912 > if you relied on the server generating self-signed certs i think it's fine to break those folks because they shouldn't have been doing that in the first place. ---

[jira] [Commented] (TINKERPOP-2023) Gremlin Server should not create self-signed certs

2018-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586058#comment-16586058 ] ASF GitHub Bot commented on TINKERPOP-2023: --- Github user robertdale comment

[GitHub] tinkerpop issue #912: TINKERPOP-2023 SSL Enhancements

2018-08-20 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/912 Right, when it's security-related, you're given a pass to break anything! :rage1: :rage2: :rage3: :rage4: Seriously, the breaking change is only if you relied on the server generatin

[jira] [Commented] (TINKERPOP-2023) Gremlin Server should not create self-signed certs

2018-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586040#comment-16586040 ] ASF GitHub Bot commented on TINKERPOP-2023: --- Github user spmallette comment

[GitHub] tinkerpop issue #912: TINKERPOP-2023 SSL Enhancements

2018-08-20 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/912 I wondered that tooi figured the reasoning for tp32 was that this was a "security" issue and thus the "breaking" aspect was justified. is that a fair way to characterize this the branch tar

[jira] [Commented] (TINKERPOP-1774) Gremlin .NET: Support min and max sizes in Connection pool

2018-08-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585638#comment-16585638 ] ASF GitHub Bot commented on TINKERPOP-1774: --- Github user jorgebay commented

[GitHub] tinkerpop pull request #903: Gremlin.Net: Add ConnectionPool min and max siz...

2018-08-20 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/903#discussion_r211183634 --- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs --- @@ -33,91 +34,134 @@ internal class ConnectionPool : IDisposable {