[GitHub] [tinkerpop] robertdale commented on issue #1042: TINKERPOP-2133 Implement index lookup for Text predicates

@skorikov I took a quick look at the change and I'm concerned about the choice of using Neo4j version 3.4.0. Let alone that the latest point release for that series is 3.4.11 (12/2018), why not just go to the latest and greatest 3.5.1 (12/2018)? [ Full content available at: https://github.com

[GitHub] [tinkerpop] robertdale commented on issue #1042: TINKERPOP-2133 Implement index lookup for Text predicates

@skorikov Please include any Neo4j upgrade notes, like we did on [TinkerPop 3.3.1](http://tinkerpop.apache.org/docs/3.4.0/upgrade/#_upgrade_neo4j), in `docs/src/upgrade/release-3.4.x.asciidoc` Also, ensure that: - all configuration properties in TinkerPop reference are current or note those re

[GitHub] [tinkerpop] robertdale commented on issue #1042: TINKERPOP-2133 Implement index lookup for Text predicates

@skorikov Please include any Neo4j upgrade notes, like we did on [TinkerPop 3.3.1](http://tinkerpop.apache.org/docs/3.4.0/upgrade/#_upgrade_neo4j), in `docs/src/upgrade/release-3.4.x.asciidoc` [ Full content available at: https://github.com/apache/tinkerpop/pull/1042 ] This message was relayed

Re: [DISCUSS] Neo4j upgrade for 3.4.1

We essentially did the same thing on 3.3. The Neo4j bump[1] - a much bigger bump at that - didn't make it in time for 3.3.0 so it went on 3.3.1. However, I would like to make sure we include in our upgrade docs any Neo4j upgrade procedures, if required, like what was done for the TinkerPop 3.3.1

[GitHub] [tinkerpop] dkuppitz commented on issue #1041: TINKERPOP-2125 Extend release validation script

PDFs are now whitelisted and the validation passes. VOTE +1 [ Full content available at: https://github.com/apache/tinkerpop/pull/1041 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] skorikov commented on issue #1042: TINKERPOP-2133 Implement index lookup for Text predicates

@spmallette Thanks! You were right, I did not run `mvn clean install` with `-DincludeNeo4j`; sorry for that. I will address the issues and update the pull request. [ Full content available at: https://github.com/apache/tinkerpop/pull/1042 ] This message was relayed via gitbox.apache.org for dev@

[GitHub] [tinkerpop] spmallette commented on issue #1041: TINKERPOP-2125 Extend release validation script

I'm not sure what those are.i assume they are just high-res versions of the png files of the same name? i guess i would just whitelist them since they've been there forever at this point. i assume we can allow *.pdf (we're really trying to mostly avoid compiled code like `.exe`, `.dl

[GitHub] [tinkerpop] skorikov commented on pull request #1042: TINKERPOP-2133 Implement index lookup for Text predicates

fixed [ Full content available at: https://github.com/apache/tinkerpop/pull/1042 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #1042: TINKERPOP-2133 Implement index lookup for Text predicates

thanks for orchestrating this pull request as i know you likely needed changes from neo4j-contrib. i think it's ok to bump to this new version of neo4j for TinkerPop 3.4.1 but since it's a major dependency change I will[ email the dev list](https://lists.apache.org/thread.html/7e96fee99fe6ce2539

[DISCUSS] Neo4j upgrade for 3.4.1

We just received this PR: https://github.com/apache/tinkerpop/pull/1042 which upgrades to the latest version of Neo4j. Ideally a dependency change this big would have been better for 3.4.0 (or now 3.5.0) but I think I'm fine upgrading it for 3.4.1. My intention is to vote positively for this PR o

[GitHub] [tinkerpop] spmallette commented on pull request #1042: TINKERPOP-2133 Implement index lookup for Text predicates

perhaps your IDE did this automatically, but could you please avoid the use of the wildcard import (that's not our code style)? [ Full content available at: https://github.com/apache/tinkerpop/pull/1042 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2133) Use neo4j index lookup in Neo4jGraphStep with HasContainers containing TextP predicates

[ https://issues.apache.org/jira/browse/TINKERPOP-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746051#comment-16746051 ] Andrey Skorikov commented on TINKERPOP-2133: Created pull request: https

[GitHub] [tinkerpop] skorikov opened pull request #1042: Implemented index lookup for Text predicates

Use index lookup for Text predicates (startingWith,endingWith,containing) in Neo4jGraphStep to improve evaluation performance. See: https://issues.apache.org/jira/browse/TINKERPOP-2133 [ Full content available at: https://github.com/apache/tinkerpop/pull/1042 ] This message was relayed via gitbo