[
https://issues.apache.org/jira/browse/TINKERPOP-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754513#comment-16754513
]
Dominik Franek commented on TINKERPOP-2143:
---
So I got it working in the for
LGTM.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1046 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[
https://issues.apache.org/jira/browse/TINKERPOP-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754271#comment-16754271
]
Ian Thomas commented on TINKERPOP-2145:
---
I tested 3.3.5 this morning and didn't
[
https://issues.apache.org/jira/browse/TINKERPOP-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754232#comment-16754232
]
Florian Hockmann commented on TINKERPOP-2145:
-
{quote}We typically set JT
[
https://issues.apache.org/jira/browse/TINKERPOP-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754149#comment-16754149
]
Ian Thomas commented on TINKERPOP-2145:
---
Thanks for the prompt responses!
I ha
[
https://issues.apache.org/jira/browse/TINKERPOP-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754045#comment-16754045
]
Florian Hockmann commented on TINKERPOP-2145:
-
Since you're using CosmosD
[
https://issues.apache.org/jira/browse/TINKERPOP-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754038#comment-16754038
]
stephen mallette commented on TINKERPOP-2145:
-
https://github.com/apache/
[
https://issues.apache.org/jira/browse/TINKERPOP-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754032#comment-16754032
]
Ian Thomas commented on TINKERPOP-2145:
---
Actually, sorry for the confusion, but
Might want to add one or two specifically for this strategy just so that it
gets exercised on graph provider systems.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
I just put some breakpoints on the lines that mutate the traversal, but it
looks like the tests in the provider test suite all have pretty optimal
traversals, hence this strategy never changes any of them.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ]
This message
[
https://issues.apache.org/jira/browse/TINKERPOP-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753992#comment-16753992
]
Ian Thomas commented on TINKERPOP-2145:
---
So far, it seems like the inconsistent
Thanks for this - merged via CTR as the change is for additional tests and
Travis passed without issue.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1050 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1050 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[
https://issues.apache.org/jira/browse/TINKERPOP-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753996#comment-16753996
]
stephen mallette commented on TINKERPOP-2145:
-
oh boy - [~Florian Hockman
Other than the few minor comments I made, I think this looks good. You have
100% coverage on the new strategy which is cool. I can't help thinking that
there is yet some case that hasn't be covered but I'm not sure what case of
significance isn't in your tests already.
Only thing I could thin
[ Full content available at: https://github.com/apache/tinkerpop/pull/1050 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
This is a pretty nice batch of test. Still thinking if there are cases that
are not covered
Are there any provider test suite tests that trigger this strategy?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ]
This message was relayed via gitbox.apache.org for dev
This is a pretty nice batch of test. Still thinking if there are cases that
are not covered
Are there any existing provider test suite tests that trigger this strategy?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ]
This message was relayed via gitbox.apache.or
could you add some javadoc like our other strategies:
https://github.com/apache/tinkerpop/blob/e51bfc90fe6a863c17016c80fe53b4b5ccb97fd0/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/CountStrategy.java#L50-L62
actually, a bit more "explaining" inli
could you add some javadoc like our other strategies:
https://github.com/apache/tinkerpop/blob/e51bfc90fe6a863c17016c80fe53b4b5ccb97fd0/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/CountStrategy.java#L50-L62
[ Full content available at: https://g
20 matches
Mail list logo
