[GitHub] [tinkerpop] FlorianHockmann commented on issue #1077: TINKERPOP-2135 Fix handling of closed idle connections in Gremlin.Net driver

2019-03-06 Thread GitHub
I just pushed a commit that adds a copy-on-write collection like the one used in the Cassandra driver and also implemented a round-robin mechanism for connection scheduling. I will try to add some tests here, especially for the new connection type. So, I removed my vote again for now. [ Full co

[jira] [Commented] (TINKERPOP-2076) TinkerPop does not build with current (v11) Java version

2019-03-06 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786108#comment-16786108 ] stephen mallette commented on TINKERPOP-2076: - Fixed the problem with the

[jira] [Commented] (TINKERPOP-2076) TinkerPop does not build with current (v11) Java version

2019-03-06 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786082#comment-16786082 ] stephen mallette commented on TINKERPOP-2076: - Just pushed a fix for the

Re: docker and GLV development

2019-03-06 Thread Robert Dale
Forgot to mention that the gremlin-python version is hardcoded. Robert Dale On Wed, Mar 6, 2019 at 2:36 PM Robert Dale wrote: > I just pushed a change that allows python tests to pass against the docker > image. > > This will install the gremlin-python script support on the server so > that's

Re: docker and GLV development

2019-03-06 Thread Robert Dale
I just pushed a change that allows python tests to pass against the docker image. This will install the gremlin-python script support on the server so that's an extra download to wait for. I had to update the localhost references to point to the docker IP in gremlin-python: grep -Rl localhost g

Re: [DISCUSS] proposed release of 3.3.6/3.4.1

2019-03-06 Thread Stephen Mallette
Thanks for sharing TINKERPOP-2169 as something to keep an eye on. Depending on the nature of the changes in the PR we could potentially merge it during code freeze. Let's see what the PR looks like. We definitely appreciate you working on that. On Wed, Mar 6, 2019 at 11:42 AM Divij Vaidya wrote

Re: [DISCUSS] proposed release of 3.3.6/3.4.1

2019-03-06 Thread Divij Vaidya
Hello I was also hoping to merge in Tinkerpop-2169 (Java GLV & server changes) as part of this release. I am actively working on it and should have the PR out by early next week. These changes are not blocker for the release but I would like to get them to hands of customers as soon as possible.

[jira] [Commented] (TINKERPOP-2076) TinkerPop does not build with current (v11) Java version

2019-03-06 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785824#comment-16785824 ] stephen mallette commented on TINKERPOP-2076: - I figured out the problem

4 Apache Events in 2019: DC Roadshow soon; next up Chicago, Las Vegas, and Berlin!

2019-03-06 Thread Rich Bowen
Dear Apache Enthusiast, (You’re receiving this because you are subscribed to one or more user mailing lists for an Apache Software Foundation project.) TL;DR: * Apache Roadshow DC is in 3 weeks. Register now at https://apachecon.com/usroadshowdc19/ * Registration for Apache Roadshow Chicago is

[GitHub] [tinkerpop] jorgebay commented on issue #1077: TINKERPOP-2135 Fix handling of closed idle connections in Gremlin.Net driver

2019-03-06 Thread GitHub
> [...] continue these two steps until we have a connection that is below the > limit, right? correct :) About the `TaskScheduler`, its just a recommendation but it doesn't have to be in scope for this iteration. [ Full content available at: https://github.com/apache/tinkerpop/pull/1077 ] This

[GitHub] [tinkerpop] FlorianHockmann commented on issue #1077: TINKERPOP-2135 Fix handling of closed idle connections in Gremlin.Net driver

2019-03-06 Thread GitHub
> the iterator is not affected by concurrent modifications (unlike concurrent > collections) This seems to depend on the collection actually. For `ConcurrentDictionary` it seems to include modifications, but for `ConcurrentQueue` not ([Source](https://docs.microsoft.com/en-us/dotnet/api/system

[GitHub] [tinkerpop] jorgebay commented on issue #1077: TINKERPOP-2135 Fix handling of closed idle connections in Gremlin.Net driver

2019-03-06 Thread GitHub
> What's the advantage of such a custom copy-on-write list? Any read operation is cheap and the iterator is not affected by concurrent modifications (unlike concurrent collections). Effectively what you get is a moment-in-time view of the collection, you don't have to add special conditions to

[jira] [Commented] (TINKERPOP-2172) PartitionStrategy doesn't apply to AddEdgeStartStep

2019-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785551#comment-16785551 ] ASF GitHub Bot commented on TINKERPOP-2172: --- spmallette commented on pull r

[GitHub] [tinkerpop] spmallette closed pull request #1078: TINKERPOP-2172 Fix PartitionStrategy to apply to AddEdgeStartStep

2019-03-06 Thread GitHub
[ pull request closed by spmallette ] [ Full content available at: https://github.com/apache/tinkerpop/pull/1078 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #1078: TINKERPOP-2172 Fix PartitionStrategy to apply to AddEdgeStartStep

2019-03-06 Thread GitHub
Thank you for this - I've cherry-picked your work to #1079 which changed the target branch and fixed up a a couple other things. I'm closing this PR in favor of that one. Take care! [ Full content available at: https://github.com/apache/tinkerpop/pull/1078 ] This message was relayed via gitbox.

[jira] [Commented] (TINKERPOP-2172) PartitionStrategy doesn't apply to AddEdgeStartStep

2019-03-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785548#comment-16785548 ] ASF GitHub Bot commented on TINKERPOP-2172: --- spmallette commented on pull r

[GitHub] [tinkerpop] spmallette opened pull request #1079: TINKERPOP-2172 Fix PartitionStrategy to apply to AddEdgeStartStep

2019-03-06 Thread GitHub
https://issues.apache.org/jira/browse/TINKERPOP-2172 Fix PartitionStrategy to apply to traversal started with addE step. I cherry-picked from #1078 to get this on `tp33` and fix up some other odds/ends. VOTE +1 [ Full content available at: https://github.com/apache/tinkerpop/pull/1079 ] This me

Re: [DISCUSS] proposed release of 3.3.6/3.4.1

2019-03-06 Thread Stephen Mallette
Wellit technically applies to the entire code base though we've rationalized late changes to GLVs using the reasoning you provided. I think that if the PR is in review on Friday that leave sufficient time to review/test if the changes must go in. If you're confident in the changes and they look

AW: [DISCUSS] proposed release of 3.3.6/3.4.1

2019-03-06 Thread Florian Hockmann
Regarding code freeze: I vaguely remember that we didn't apply that to GLVs once, but is that our general policy or was it only an exception? (The reasoning was that the GLVs aren't used by providers to check a new release if I remember it correctly.) I'm just asking because of these two .NET i