[GitHub] [tinkerpop] rdtr commented on pull request #1235: TINKERPOP-2320 allow to pass custom XmlInputFactory when instantiating GraphMLReader

2019-12-16 Thread GitHub
Sorry I was lazy... this should have been ``` if (this.inputFactory == null) ``` I updated the PR. Thanks! [ Full content available at: https://github.com/apache/tinkerpop/pull/1235 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on pull request #1235: TINKERPOP-2320 allow to pass custom XmlInputFactory when instantiating GraphMLReader

2019-12-16 Thread GitHub
No need to add the JIRA number - those get added separately on release. [ Full content available at: https://github.com/apache/tinkerpop/pull/1235 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] rdtr commented on issue #1230: TINKERPOP-2320 allow to pass custom XmlInputFactory when instantiating GraphMLReader

2019-12-16 Thread GitHub
I just created a new PR: https://github.com/apache/tinkerpop/pull/1235 Let's continue the discussion there. Thanks! [ Full content available at: https://github.com/apache/tinkerpop/pull/1230 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2320) [SECURITY] XMLInputFactory initialization in GraphMLReader introduces

2019-12-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997569#comment-16997569 ] ASF GitHub Bot commented on TINKERPOP-2320: --- rdtr commented on pull request #1235:

[GitHub] [tinkerpop] rdtr opened pull request #1235: TINKERPOP-2320 allow to pass custom XmlInputFactory when instantiating GraphMLReader

2019-12-16 Thread GitHub
This pull request is a revised one from https://github.com/apache/tinkerpop/pull/1230. Some provider wants to use XMLInputFactory with more secure configurations. This change makes it possible to pass XMLInputFactory when instantiating GraphMLReader. I don't add any tests right now, I want to

[GitHub] [tinkerpop] rdtr commented on issue #1230: TINKERPOP-2320 allow to pass custom XmlInputFactory when instantiating GraphMLReader

2019-12-16 Thread GitHub
Sorry, rebasing directly on Github UI seems not a good solution to base onto `tp34`... I will make another PR. Thanks. [ Full content available at: https://github.com/apache/tinkerpop/pull/1230 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2320) [SECURITY] XMLInputFactory initialization in GraphMLReader introduces

2019-12-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997558#comment-16997558 ] ASF GitHub Bot commented on TINKERPOP-2320: --- rdtr commented on pull request #1230:

[jira] [Commented] (TINKERPOP-2175) Executor thread is not returned on channel close

2019-12-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997538#comment-16997538 ] ASF GitHub Bot commented on TINKERPOP-2175: --- spmallette commented on pull request #1234:

[jira] [Closed] (TINKERPOP-2247) Server should respect charset specified in request header

2019-12-16 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette closed TINKERPOP-2247. --- Resolution: Won't Do Closing given my previous comment... > Server should

[jira] [Closed] (TINKERPOP-1017) Get InputRDDFormat to work with Multiple Splits

2019-12-16 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette closed TINKERPOP-1017. --- Resolution: Won't Do > Get InputRDDFormat to work with Multiple Splits >

[jira] [Closed] (TINKERPOP-1015) InputRDD and InputFormat to load into HadoopGraph from any Graph System

2019-12-16 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette closed TINKERPOP-1015. --- Resolution: Won't Do As there was never any real user feedback on this one and

[jira] [Commented] (TINKERPOP-2315) Implement some form of clone() or reset() for Traversal in GLVs

2019-12-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997450#comment-16997450 ] ASF GitHub Bot commented on TINKERPOP-2315: --- spmallette commented on pull request #1233:

[jira] [Closed] (TINKERPOP-2307) Add better error message for badly configured Channelizer

2019-12-16 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette closed TINKERPOP-2307. --- Fix Version/s: 3.3.10 3.4.5 3.5.0

[jira] [Commented] (TINKERPOP-2262) Improve Netty protocol handling

2019-12-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997355#comment-16997355 ] ASF GitHub Bot commented on TINKERPOP-2262: --- spmallette commented on pull request #1232:

[jira] [Closed] (TINKERPOP-2326) the query which contains the 'within' statement do not use the index, the query speed is too slower(in the neo4j-gremlin module)

2019-12-16 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette closed TINKERPOP-2326. --- Resolution: Duplicate I hope you don't mind but I'm going to merge this issue

[jira] [Updated] (TINKERPOP-1575) Improve use of Neo4j indicies for common searches

2019-12-16 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette updated TINKERPOP-1575: Description: When using a Neo4j-based graph, indicies are not used when more

[GitHub] [tinkerpop] spmallette opened pull request #1231: TINKERPOP-2266 Start keep alive polling on Connection construction

2019-12-16 Thread GitHub
https://issues.apache.org/jira/browse/TINKERPOP-2266 If nothing writes to the Connection then keep alive doesn't start which might let it die in the pool if it is not used at some point. Builds with `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false` VOTE +1 [

[jira] [Commented] (TINKERPOP-2266) Keep alive not started at connection creation

2019-12-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997234#comment-16997234 ] ASF GitHub Bot commented on TINKERPOP-2266: --- spmallette commented on pull request #1231: