[
https://issues.apache.org/jira/browse/TINKERPOP-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053719#comment-17053719
]
ASF GitHub Bot commented on TINKERPOP-2347:
---
spmallette commented on pull r
[
https://issues.apache.org/jira/browse/TINKERPOP-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephen Mallette closed TINKERPOP-2347.
---
Fix Version/s: 3.4.7
3.3.11
3.5.0
A
[
https://issues.apache.org/jira/browse/TINKERPOP-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053642#comment-17053642
]
ASF GitHub Bot commented on TINKERPOP-2347:
---
olim7t commented on pull reque
[
https://issues.apache.org/jira/browse/TINKERPOP-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053546#comment-17053546
]
Stephen Mallette commented on TINKERPOP-2347:
-
Since this change isn't br
Any reason why you didn't simply call `SendAsync` here? I think it would be
good if we wouldn't have to duplicate the code to serialize and send a message.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1257 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop
(nitpick) Again: **s**tring
[ Full content available at: https://github.com/apache/tinkerpop/pull/1257 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
(nitpick) **s**tring (it's just the usual C# code style)
[ Full content available at: https://github.com/apache/tinkerpop/pull/1257 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
One other idea I just got, how about adding a private property like this:
```c#
private bool IsSessionEnabled => !string.IsNullOrEmpty(_sessionId);
```
then this if clause could be changed to:
```c#
if (IsSessionEnabled)
```
which is easer to understand in my opinion.
But this if course only a
Florian Hockmann created TINKERPOP-2349:
---
Summary: Switch from Newtonsoft.Json to System.Text.Json
Key: TINKERPOP-2349
URL: https://issues.apache.org/jira/browse/TINKERPOP-2349
Project: TinkerPop
Florian Hockmann created TINKERPOP-2348:
---
Summary: Enable nullable checks
Key: TINKERPOP-2348
URL: https://issues.apache.org/jira/browse/TINKERPOP-2348
Project: TinkerPop
Issue Type: Im
[
https://issues.apache.org/jira/browse/TINKERPOP-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florian Hockmann updated TINKERPOP-2288:
Fix Version/s: (was: 3.4.7)
(was: 3.5.0)
> Get Conne
[
https://issues.apache.org/jira/browse/TINKERPOP-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florian Hockmann reopened TINKERPOP-2288:
-
Assignee: (was: Florian Hockmann)
[~spmallette] The issue isn't resolve
[
https://issues.apache.org/jira/browse/TINKERPOP-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephen Mallette closed TINKERPOP-2288.
---
Fix Version/s: 3.4.7
3.5.0
Assignee: Florian Hockmann
[
https://issues.apache.org/jira/browse/TINKERPOP-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florian Hockmann closed TINKERPOP-2192.
---
Fix Version/s: 3.4.7
3.5.0
Resolution: Fixed
> Gremlin.
[
https://issues.apache.org/jira/browse/TINKERPOP-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053421#comment-17053421
]
ASF GitHub Bot commented on TINKERPOP-2192:
---
FlorianHockmann commented on p
> Thanks for the contribution, @heljoyLiu! The PR looks good at a first glance,
> but I'll need some more time to do a full review.
> I'm not sure if you're aware of that but the Gremlin.NET driver has changed a
> lot between `3.3-dev` and `3.4-dev`, so if you want this change to go into
> `3.3-
[
https://issues.apache.org/jira/browse/TINKERPOP-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053328#comment-17053328
]
ASF GitHub Bot commented on TINKERPOP-2288:
---
FlorianHockmann commented on p
17 matches
Mail list logo
