[jira] [Commented] (TINKERPOP-2353) Error while Shutting Down Gremlin Server

2020-03-25 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067027#comment-17067027 ] Stephen Mallette commented on TINKERPOP-2353: - The PR should resolve this problem. I was

[jira] [Commented] (TINKERPOP-2353) Error while Shutting Down Gremlin Server

2020-03-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067019#comment-17067019 ] ASF GitHub Bot commented on TINKERPOP-2353: --- spmallette commented on pull request #1270:

[GitHub] [tinkerpop] spmallette opened pull request #1270: TINKERPOP-2353 Added some checks for null in shutdown of server

2020-03-25 Thread GitHub
https://issues.apache.org/jira/browse/TINKERPOP-2353 The `null` checks seem necessary as failures in `GraphManager` initialization can leave Gremlin Server in a state where it is partially setup so that when shutdown starts those components that were not initialized end up being null and calls

[GitHub] [tinkerpop] FlorianHockmann opened pull request #1269: TINKERPOP-2350 Fixed bug in Traversal.clone() in Gremlin.NET

2020-03-25 Thread GitHub
https://issues.apache.org/jira/browse/TINKERPOP-2350 This is basically the same fix for .NET as #1268 for Python. This also includes the commit from #1268 so I'll rebase this once that PR is merged. VOTE +1 [ Full content available at: https://github.com/apache/tinkerpop/pull/1269 ] This

[jira] [Commented] (TINKERPOP-2350) clone() is not deep copying Traversal internals

2020-03-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066799#comment-17066799 ] ASF GitHub Bot commented on TINKERPOP-2350: --- FlorianHockmann commented on pull request

[jira] [Created] (TINKERPOP-2354) Document recommendation to reuse graph traversal source

2020-03-25 Thread Florian Hockmann (Jira)
Florian Hockmann created TINKERPOP-2354: --- Summary: Document recommendation to reuse graph traversal source Key: TINKERPOP-2354 URL: https://issues.apache.org/jira/browse/TINKERPOP-2354 Project:

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1268: TINKERPOP-2350 Fixed bug in Traversal.clone() in gremlin-python

2020-03-25 Thread GitHub
(nitpick) Any reason not to use the anonymous traversal source here? [ Full content available at: https://github.com/apache/tinkerpop/pull/1268 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Updated] (TINKERPOP-2353) Error while Shutting Down Gremlin Server

2020-03-25 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette updated TINKERPOP-2353: Description: I have a kubernetes environment where gremlin server is running

[GitHub] [tinkerpop] heljoyLiu commented on issue #1263: dotnet: add session mode connection

2020-03-25 Thread GitHub
> > so, configure for connection pool should be set in .Net as 4 conns in pool > > by default, is't ? > > I don't think it's quite as easy as a change of the default, because someone > could reconfigure it back to something other than 1. The Java driver has a > way of preventing the user from

[GitHub] [tinkerpop] spmallette commented on issue #1263: dotnet: add session mode connection

2020-03-25 Thread GitHub
> so, configure for connection pool should be set in .Net as 4 conns in pool by > default, is't ? I don't think it's quite as easy as a change of the default, because someone could reconfigure it back to something other than 1. The Java driver has a way of preventing the user from doing that

[GitHub] [tinkerpop] spmallette commented on issue #1268: TINKERPOP-2350 Fixed bug in Traversal.clone() in gremlin-python

2020-03-25 Thread GitHub
I'll modify the ticket to include .NET 臘‍♂ - we can re-use it for your separate PR. thanks for testing/fixing in .NET [ Full content available at: https://github.com/apache/tinkerpop/pull/1268 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Updated] (TINKERPOP-2350) clone() is not deep copying Traversal internals

2020-03-25 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette updated TINKERPOP-2350: Component/s: dotnet > clone() is not deep copying Traversal internals >

[GitHub] [tinkerpop] FlorianHockmann commented on issue #1263: dotnet: add session mode connection

2020-03-25 Thread GitHub
> I tried to merge this through to master and the test in this PR fails. It only failed when you had it merged into `master` locally? Any idea why it doesn't already fail on `3.4-dev` / in this PR? > I guess that .NET doesn't end up using the same channel for sessions the way > that the Java