[GitHub] [tinkerpop] heljoyLiu commented on issue #1264: gremlin-python: add session mode client

2020-04-01 Thread GitHub
> If you'd like to add that here on this PR that will be fine, though for some > reason you target `3.4-dev` with this PR but all other languages went to > `3.3-dev` - I think this change should be re-targetted to `3.3-dev` to be > consistent at this point. Please let me know if you think diffe

Re: [DISCUSS] ASF Board Draft Report - April 2020

2020-04-01 Thread Stephen Mallette
I've submitted the report to the board - that was a good one! On Mon, Mar 30, 2020 at 2:06 PM Stephen Mallette wrote: > Josh Perryman suggested some more color be added to the > 3.4.5--hotfix-->3.4.6. I thought that was a good idea and ended up > re-writing most of the report. Please re-read: >

[GitHub] [tinkerpop] spmallette commented on issue #1269: TINKERPOP-2350 Fixed bug in Traversal.clone() in Gremlin.NET

2020-04-01 Thread GitHub
VOTE +1 [ Full content available at: https://github.com/apache/tinkerpop/pull/1269 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #1264: gremlin-python: add session mode client

2020-04-01 Thread GitHub
I referenced this one from #1263 (`3.4-dev`)which added sessions for .NET. it is linked with #1257 (`3.3-dev`) and #1251 (javascript) With the addition of this PR it would mean that we have session support across all internally managed drivers. So far, I'm not sure if any of these changes have a

[GitHub] [tinkerpop] spmallette commented on issue #1263: dotnet: add session mode connection

2020-04-01 Thread GitHub
The tests now pass on `master`, which solves my original issues with this PR. In that sense, VOTE +1. There remains a bit of question about documentation, but perhaps we could just have unified documentation for all GLVs that picked up this feature after #1264 is merged. [ Full content avail

[GitHub] [tinkerpop] FlorianHockmann commented on issue #1263: dotnet: add session mode connection

2020-04-01 Thread GitHub
LGTM again, so my VOTE is +1 again. [ Full content available at: https://github.com/apache/tinkerpop/pull/1263 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1273: TINKERPOP-2349 Migrate JSON serialization to System.Text.Json in Gremlin.NET

2020-04-01 Thread GitHub
Good to know. Then I'll remove this target again. [ Full content available at: https://github.com/apache/tinkerpop/pull/1273 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay commented on pull request #1273: TINKERPOP-2349 Migrate JSON serialization to System.Text.Json in Gremlin.NET

2020-04-01 Thread GitHub
It will be resolved automatically for `netcoreapp3.0` users. [ Full content available at: https://github.com/apache/tinkerpop/pull/1273 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Updated] (TINKERPOP-2349) Switch from Newtonsoft.Json to System.Text.Json

2020-04-01 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette updated TINKERPOP-2349: Affects Version/s: 3.5.0 > Switch from Newtonsoft.Json to System.Text.Json > --

[jira] [Updated] (TINKERPOP-2349) Switch from Newtonsoft.Json to System.Text.Json

2020-04-01 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette updated TINKERPOP-2349: Labels: breaking (was: ) > Switch from Newtonsoft.Json to System.Text.Json > -

[jira] [Commented] (TINKERPOP-2353) Error while Shutting Down Gremlin Server

2020-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072639#comment-17072639 ] ASF GitHub Bot commented on TINKERPOP-2353: --- spmallette commented on pull r

[jira] [Closed] (TINKERPOP-2353) Error while Shutting Down Gremlin Server

2020-04-01 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette closed TINKERPOP-2353. --- Fix Version/s: 3.4.7 3.3.11 3.5.0 A

[jira] [Commented] (TINKERPOP-2349) Switch from Newtonsoft.Json to System.Text.Json

2020-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072603#comment-17072603 ] ASF GitHub Bot commented on TINKERPOP-2349: --- FlorianHockmann commented on p

[GitHub] [tinkerpop] FlorianHockmann opened pull request #1273: TINKERPOP-2349 Migrate JSON serialization to System.Text.Json in Gremlin.NET

2020-04-01 Thread GitHub
https://issues.apache.org/jira/browse/TINKERPOP-2349 .NET Core 3.0 is added as a target framework as it already includes support for `System.Text.Json` and therefore doesn't need the NuGet package. Results from a simple benchmark with BenchmarkDotNet showed that this improves the performance of