Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/772
No worries, thanks!
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/772
@spmallette I'm not sure I'll come back to this exactly. I was thinking
about it recently, actually, and I think just providing a `create()` which
calls `create(null)` in the VertexProgramBuilder
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/829
Thank you!
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/772
@spmallette Thanks for the heads-up, but I don't think I'll have a chance
to get to it before then. It isn't so urgent it can't wait for the next release
as it's code style as opposed to a bug.
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/804
This looks good to me. Thanks for fixing the Spark and Giraph versions as
well, @spmallette.
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/801
OK, I've made that update and now this build passes.
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/801
I'm not sure why this is failing, it's due to something with the
javascript. I don't know how my changes potentially affected that.
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/801
Done
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/801
I'll modify and let you know when I'm done so that I make sure it's setup
as I need. For my test I need not just a self-edge but also an edge to another
vertex.
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/801
@spmallette : I believe this is ready now if you can run the Docker test:
`docker/build.sh -t -n -i`
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/801
Never mind, I think I got it.
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/801
Hi @spmallette, I'm trying to add to the kitchen sink graph for my message
passing test and I want to make sure I'm doing it right. I'm doing this in Java
and calling a custom `main
GitHub user PBGraff opened a pull request:
https://github.com/apache/tinkerpop/pull/801
TINKERPOP-1862 TinkerMessenger proper handling of Direction.BOTH
New PR based off of #777 re-based on new head of tp32 branch. Need to
update toy graph merged in #794 with scenario for this test
Github user PBGraff closed the pull request at:
https://github.com/apache/tinkerpop/pull/777
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/777
Great, thanks. I haven't been able to work on this recently but having that
merged will help. I'll check it out and update my test as well as fix the git
history of the branch for this and #772.
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/777
Thanks, @spmallette. Regarding the re-basing, I think I just managed that...
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/777
I'll look, but I was also particularly interested in having a self-loop
edge to make sure that those are handled correctly as well.
---
Github user PBGraff commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/772#discussion_r162138049
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/VertexProgram.java
---
@@ -219,13 +234,28 @@ public default void
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/777
Tests pass now, good to go from me.
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/772
I think all test problems have now been fixed. My concern is that people
may still override/implement the old method and not the new one, thus yielding
programs that don't execute properly
Github user PBGraff commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/772#discussion_r161387759
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/bulkloading/BulkLoaderVertexProgram.java
---
@@ -325,9 +325,12
Github user PBGraff commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/772#discussion_r161387762
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/VertexProgram.java
---
@@ -68,7 +68,20 @@ public default void
Github user PBGraff commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/772#discussion_r161387752
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/step/VertexComputing.java
---
@@ -53,7 +53,19
Github user PBGraff commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/772#discussion_r161387755
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/clustering/peerpressure/PeerPressureVertexProgram.java
---
@@ -81,7
Github user PBGraff commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/772#discussion_r161387754
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/ranking/pagerank/PageRankVertexProgram.java
---
@@ -75,7 +75,11
Github user PBGraff commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/772#discussion_r161387751
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/step/map/PageRankVertexProgramStep.java
---
@@ -83,17
Github user PBGraff commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/772#discussion_r161387742
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/step/map/VertexProgramStep.java
---
@@ -64,15 +64,15
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/777
@spmallette Updated PR from https://github.com/apache/tinkerpop/pull/770
---
GitHub user PBGraff opened a pull request:
https://github.com/apache/tinkerpop/pull/777
TINKERPOP-1862 TinkerMessenger proper handling of Direction.BOTH
New PR targeted to `tp32` branch. Fixes `TinkerMessenger` handling of
direction to get the correct messages. Also now adds a set
Github user PBGraff closed the pull request at:
https://github.com/apache/tinkerpop/pull/770
---
GitHub user PBGraff opened a pull request:
https://github.com/apache/tinkerpop/pull/772
TINKERPOP-1861 Modify VertexProgram Builder to take varargs Graphs
VertexProgram.Builder.create() now takes varargs Graphs instead of just a
single Graph. This change has been propagated through
Github user PBGraff closed the pull request at:
https://github.com/apache/tinkerpop/pull/768
---
GitHub user PBGraff opened a pull request:
https://github.com/apache/tinkerpop/pull/770
TINKERPOP-1862 TinkerMessenger proper handling of Direction.BOTH
This PR presents a fix for `TinkerMessenger` that handled `Direction.BOTH`
by identifying the `Vertex` that is not the one
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/768
@spmallette We can apply this to the TP 3.2.x line as well. Should I modify
the PR to apply to the tp32 branch instead?
---
GitHub user PBGraff opened a pull request:
https://github.com/apache/tinkerpop/pull/768
WIP: Modify VertexProgram.Builder.create() to take Graph as varargs
VertexProgram.Builder.create() now takes varargs Graph instead of just
Graph. This change has been propagated through all
35 matches
Mail list logo
