Github user ashwinisingh01 commented on the issue:
https://github.com/apache/tinkerpop/pull/915
Sure
From: Patrik Husfloen
Sent: Thursday, September 20, 2018 6:12 AM
To: apache/tinkerpop
Cc: Ashwini Singh ; Mention
Subject: Re: [apache/tinkerpop] Tinkerpop
Github user ashwinisingh01 commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@redoz , I see your push in the PR. I hope you are unblocked to make
changes directly to the PR. Let me know if you still need help
---
Github user ashwinisingh01 commented on the issue:
https://github.com/apache/tinkerpop/pull/915
You have push access to the repo. Is there some other setting that I am
missing ?
[cid:image001.png@01D44A9F.B8EE7DC0]
From: Patrik Husfloen
Sent: Wednesday
Github user ashwinisingh01 commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@redoz , Instead of managing multiple forks. I gave you access to the repo,
please update this PR directly. I really appreciate you taking a stab at some
the items here.
---
Github user ashwinisingh01 commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@redoz , Can you submit a PR to TINKERPOP-1913 of my fork
https://github.com/ashwinisingh01/tinkerpop? I can merge and update the PR.
This branch is used by other folks
Github user ashwinisingh01 commented on the issue:
https://github.com/apache/tinkerpop/pull/915
Thanks Patrik. I will get back to before EOW and wrap up on open comments.
Get Outlook for Android<https://aka.ms/ghei36>
From: Patrik Husfloen
Github user ashwinisingh01 commented on the issue:
https://github.com/apache/tinkerpop/pull/915
This commit de1d7e5 is before the rebase. During rebase, I took the
remote version. Did I mess something during the rebase? Why I see the java
changes in the PR?. I did not change
Github user ashwinisingh01 commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/915#discussion_r212578829
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/IResultSet.cs ---
@@ -0,0 +1,43 @@
+#region License
+/*
+ * Licensed to the Apache
Github user ashwinisingh01 commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/915#discussion_r212572593
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientTests.cs ---
@@ -51,7 +52,18 @@ public async Task
Github user ashwinisingh01 commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/915#discussion_r212572266
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ResultSet.cs ---
@@ -0,0 +1,85 @@
+#region License
+/*
+ * Licensed to the Apache
Github user ashwinisingh01 commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/915#discussion_r212572306
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ResultSet.cs ---
@@ -0,0 +1,85 @@
+#region License
+/*
+ * Licensed to the Apache
Github user ashwinisingh01 commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/915#discussion_r212571268
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ResultSet.cs ---
@@ -0,0 +1,85 @@
+#region License
+/*
+ * Licensed to the Apache
Github user ashwinisingh01 commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/915#discussion_r212570945
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ResultSet.cs ---
@@ -0,0 +1,85 @@
+#region License
+/*
+ * Licensed to the Apache
Github user ashwinisingh01 commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/915#discussion_r212570517
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/Connection.cs ---
@@ -116,9 +118,9 @@ private async Task>
ReceiveAs
Github user ashwinisingh01 commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/915#discussion_r212568994
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/IResultSet.cs ---
@@ -0,0 +1,43 @@
+#region License
+/*
+ * Licensed to the Apache
Github user ashwinisingh01 commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@redoz , Can you take up adding statusattribute to ResponseException on top
of my change
---
Github user ashwinisingh01 commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@spmallette , looks like these two commits the missing in upstream
TINKERPOP-1913
a6625d3
ed3894b
Looks like these two commits are missing in current upstream
Github user ashwinisingh01 commented on the issue:
https://github.com/apache/tinkerpop/pull/915
Thanks, I will address the suggestion and update the PR.
---
Github user ashwinisingh01 commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@FlorianHockmann , Not really ,the username is not intentional :) . I think
git picked up that name from some git configuration on the machine.
---
Github user ashwinisingh01 commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@spmallette , Since I lost the access to the original account ashwini-ms. I
do not have permission to close the PR #868 . Does admin of this repo have
permissions?
---
Github user ashwinisingh01 commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/915#discussion_r210118497
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientTests.cs ---
@@ -51,7 +52,18 @@ public async Task
Github user ashwinisingh01 commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/868#discussion_r210117108
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/Connection.cs ---
@@ -114,11 +116,18 @@ internal class Connection : IConnection
Github user ashwinisingh01 commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/868#discussion_r210115520
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ResultSet.cs ---
@@ -0,0 +1,99 @@
+#region License
+
+/*
+ * Licensed
Github user ashwinisingh01 commented on the issue:
https://github.com/apache/tinkerpop/pull/868
@spmallette , @FlorianHockmann , I recovered the github recently account
but had to change the user-name unfortunately. I created another PR for this
change, following up on the review
GitHub user ashwinisingh01 opened a pull request:
https://github.com/apache/tinkerpop/pull/915
Tinkerpop 1913-Followup
Adding support to de-serialize status attribute for gremlin dotnet.
More details : https://issues.apache.org/jira/browse/TINKERPOP-1913
Following
25 matches
Mail list logo
