Github user jorgebay commented on the pull request:
https://github.com/apache/tinkerpop/commit/2bf649c22a86f6051dc932d016a4a0bee4756ad0#commitcomment-24544868
In gremlin-test/features/map/Select.feature:
In gremlin-test/features/map/Select.feature on line 25:
Shouldn't
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/719
dotnet tests pass on docker ð
Relevant lines:
```
Test run for
/usr/src/tinkerpop/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/bin/Release/netcoreapp1.0
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/719
Maybe I have to remove the previous tinkerpop:base image?
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/719
I've got a failure on Gremlin Python:
```
[INFO] --- maven-antrun-plugin:1.8:run (setup-py-env) @ gremlin-python ---
[WARNING] Parameter tasks is deprecated, use target instead
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/712
I wont be able to review it today, I'll probably have some time to look
into this early next week.
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/716
`dotnet pack gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj -c Release`
generates the package containing with assembly with the intended attributes.
VOTE +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/710
Rebased onto master, tests pass with `mvn clean install -P gremlin-dotnet`.
VOTE +1
I'll merge it once CI jobs finish.
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/716
We forgot to consider that, as we are strong named assembly, we must avoid
changing the assembly version for patch versions to minimize the need of
user-defined binding redirects
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/716
The strong name for Gremlin.Net.dll assembly (generated using
Gremlin.Net.csproj) is missing, we should add it in the template as well.
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/704
It's weird because 6a3fc39a912bec98707dd69d461955330627df10 was merged by
@spmallette on master in 75502eef222b0dfc7aa83c2456ab319a9f9dd1a6 (he beat me
to it because I was taking too long to do
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/710
Thanks @FlorianHockmann for the feedback.
I've addressed the issues you mentioned.
About `ValueMap<TKey, TValue>()`, we can continue the discussion on the
mailing list:
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/710#discussion_r138317662
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/DriverRemoteConnection/GraphTraversalTests.cs
---
@@ -102,9 +102,9
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/710
TINKERPOP-1730 Gremlin .NET: add support for GraphSON3
https://issues.apache.org/jira/browse/TINKERPOP-1730
You can merge this pull request into a Git repository by running:
$ git pull
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/704
About request pipelining, you can send in a queue one by one regardless of
whether or not it was received. On the read side, once a message is received
you issue a following call
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
I've removed support for Nashorn as part of #626 (see first comment).
JavaScript engines don't provide a standard way to deal with and import
modules, so supporting with multiple runtimes
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/704
I've left some line comments on the pr.
Apart from the issue this patch is addressing, we should create separate
tickets for issues related to the .NET driver pool:
- Blocking (use
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/704#discussion_r137214097
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs ---
@@ -74,6 +85,36 @@ private void AddConnection(Connection connection
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/704#discussion_r137213383
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs ---
@@ -74,6 +85,36 @@ private void AddConnection(Connection connection
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
Great! It would be really nice to have a working
`GremlinJavaScriptScriptEngine`!
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/695
VOTE +1
`mvn clean install -DskipIntegrationTests=false` passes.
API summary:
- All methods are generated using groovy template files.
- Naming conventions for js
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/695
TINKERPOP-1489 JavaScript GLV
https://issues.apache.org/jira/browse/TINKERPOP-1489
Submitting the JavaScript for review to merge into tp32 after 3.2.6 code
freeze and release
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/690
Does any other contributor has time to look into this PR?
I would like to include it before the code freeze as it involves an API
change (different exceptions thrown).
---
If your project
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/690
VOTE: +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/690#discussion_r132183072
--- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs ---
@@ -0,0 +1,55 @@
+#region License
+
+/*
+ * Licensed to the Apache
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/690#discussion_r132153295
--- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs ---
@@ -0,0 +1,55 @@
+#region License
+
+/*
+ * Licensed to the Apache
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/690#discussion_r132153059
--- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs ---
@@ -0,0 +1,55 @@
+#region License
+
+/*
+ * Licensed to the Apache
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/690
Sorry, I've messed up with the name of the pull request, affecting JIRA
ticket 1445 logs...
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/690
TINKERPOP-1445 Unwrap AggregateException for sync io operations
https://issues.apache.org/jira/browse/TINKERPOP-1744
Includes a test expecting the underlying exception
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/670
I've added support for GraphSON3 on the Gremlin .NET:
- Added `GraphSON3Writer` and `GraphSON3Reader`.
- Modified unit tests to run using GraphSON2 and GraphSON2.
I'm getting
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/670
np really!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/670
I've reused the `methodsWithSpecificTypes` to generate `ValueMap()` with 2
type parameters.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/670
I'm looking into the `g_V_HasXname_markoX_ValueMap_Next` failure on
gremlin-dotnet, it looks like the generation process was producing:
```
public GraphTraversal<S, IDiction
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/629
Apart from my previous comment, lgtm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/629#discussion_r122383928
--- Diff: gremlin-dotnet/glv/AnonymousTraversal.template ---
@@ -27,6 +27,8 @@ using Gremlin.Net.Structure;
// THIS IS A GENERATED FILE - DO
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/626
You can run the Node.js tests using `mvn clean install
-DskipIntegrationTests=false`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/626
Update Javascript GLV
Address feedback and provide maven integration:
- Reorganize gremlin-javascript into node.js project
- Simplify javascript code generators
- Generate
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/625
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/623
lgtm! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/622
TINKERPOP-1552: Remove unintended comment
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jorgebay/tinkerpop csharp-glv-generics-fixes
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/620
cc @FlorianHockmann
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/620
TINKERPOP-1552 C# GLV: Generics and enum generation
Added type safety to traversal interface. For example:
```csharp
Vertex vertex = g.V().Next();
// Compile time error
Edge
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/619
I gave the C# solution a try and all namespaces are nested within
`Gremlin.Net`: `Gremlin.Net.Driver`, `Gremlin.Net.Process` and
`Gremlin.Net.Structure`.
Looks good to me! +1
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/450
ok thanks!
I hope I'll get some time soon to work on the JavaScript GLV to leverage
the new async execution introduced in TINKERPOP-1490.
---
If your project is set up for it, you can reply
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/450
> Note that there is a proposal for adding async iterator to JavaScript.
Nice! I wasn't aware of that, I really like the syntax!
I think the destiny of `next()` for async ops is a
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/478
> What makes `toListAsync()` more "fully async" compared to
`promise(traversal::toList)`? Internally, from a Java perspective anyway,
`toListAsync()` does the same t
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/450
I've added some fixes during the past weeks.
I'll try to summarize the open issues with this patch to try to unblock it:
A) Currently, the javascript GLV exposes `list()` instead
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/450#discussion_r82168010
--- Diff: gremlin-javascript/pom.xml ---
@@ -0,0 +1,132 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/450#discussion_r82163673
--- Diff: gremlin-javascript/pom.xml ---
@@ -0,0 +1,132 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/450
1: I mentioned the difficulty of delivering a `RemoteConnection`
implementation inside the TinkerPop repository above.
2: I commented in TINKERPOP-1490 that `async` is a reserved keyword
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/450
Thanks @PommeVerte for getting a first look at it so fast.
About `list()` and `one()`:
- `next()` is a method exposed by the [Iterator protocol][1] which in newer
versions
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/450
Javascript GLV
For [TINKERPOP-1489](https://issues.apache.org/jira/browse/TINKERPOP-1489).
- Should work with any ES5 engine that supports CommonJs: tested with
Nashorn and Node.js
201 - 251 of 251 matches
Mail list logo
